[TRIVIAL] aic7xxx_Makefile fix

[TRIVIAL] aic7xxx_Makefile fix

[Rusty Trivial Russell]

From:  junio@siamese.dyndns.org

  Patch against 2.4.19.  If you are in a (good) habit of making
  all the upstream sources read-only before starting your build,
  generation of the firmware code fails because it tries to write
  into read-only files.  This bites only in configurations where
  CONFIG_AIC7XXX_BUILD_FIRMWARE is set to 'y'. 
  

--- trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile.orig	2002-12-16 17:22:40.000000000 +1100
+++ trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile	2002-12-16 17:22:40.000000000 +1100
@@ -39,6 +39,7 @@
 $(obj-aic7xxx): aic7xxx_reg.h
 
 aic7xxx_seq.h aic7xxx_reg.h: aic7xxx.seq aic7xxx.reg aicasm/aicasm
+	rm -f aic7xxx_seq.h aic7xxx_reg.h
 	aicasm/aicasm -I. -r aic7xxx_reg.h -o aic7xxx_seq.h aic7xxx.seq
 endif
 
-- 
  Don't blame me: the Monkey is driving
  File: junio@siamese.dyndns.org: [TRIVIAL] aic7xxx_Makefile fix

Re: [TRIVIAL] aic7xxx_Makefile fix

[Kai Germaschewski]

On Mon, 16 Dec 2002, Rusty Trivial Russell wrote:

> From:  junio@siamese.dyndns.org
> 
>   Patch against 2.4.19.  If you are in a (good) habit of making
>   all the upstream sources read-only before starting your build,
>   generation of the firmware code fails because it tries to write
>   into read-only files.  This bites only in configurations where
>   CONFIG_AIC7XXX_BUILD_FIRMWARE is set to 'y'. 
>   
> 
> --- trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile.orig	2002-12-16 17:22:40.000000000 +1100
> +++ trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile	2002-12-16 17:22:40.000000000 +1100
> @@ -39,6 +39,7 @@
>  $(obj-aic7xxx): aic7xxx_reg.h
>  
>  aic7xxx_seq.h aic7xxx_reg.h: aic7xxx.seq aic7xxx.reg aicasm/aicasm
> +	rm -f aic7xxx_seq.h aic7xxx_reg.h
>  	aicasm/aicasm -I. -r aic7xxx_reg.h -o aic7xxx_seq.h aic7xxx.seq
>  endif

This is 2.4, so I don't feel authorative for that ;) Anyhow, this is not a
right fix (it's fixed properly in 2.5). Overwriting shipped files should
never happen, the "rm" may fix the symptoms for some cases, but SCS as
e.g. bitkeeper will generally not be happy with that kind of behavior.

--Kai

Re: [TRIVIAL] aic7xxx_Makefile fix

[Rusty Russell]

In message <Pine.LNX.4.44.0212161527350.21707-100000@chaos.physics.uiowa.edu> y
ou write:
> On Mon, 16 Dec 2002, Rusty Trivial Russell wrote:
> 
> > From:  junio@siamese.dyndns.org
> > 
> >   Patch against 2.4.19.  If you are in a (good) habit of making
> >   all the upstream sources read-only before starting your build,
> >   generation of the firmware code fails because it tries to write
> >   into read-only files.  This bites only in configurations where
> >   CONFIG_AIC7XXX_BUILD_FIRMWARE is set to 'y'. 
> >   
> > 
> > --- trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile.orig	2002-12-16 17:22:40.000000000 +1100
> > +++ trivial-2.4.21-pre1/drivers/scsi/aic7xxx/Makefile	2002-12-16 17:22:40.000000000 +1100
> > @@ -39,6 +39,7 @@
> >  $(obj-aic7xxx): aic7xxx_reg.h
> >  
> >  aic7xxx_seq.h aic7xxx_reg.h: aic7xxx.seq aic7xxx.reg aicasm/aicasm
> > +	rm -f aic7xxx_seq.h aic7xxx_reg.h
> >  	aicasm/aicasm -I. -r aic7xxx_reg.h -o aic7xxx_seq.h aic7xxx.seq
> >  endif
> 
> This is 2.4, so I don't feel authorative for that ;) Anyhow, this is not a
> right fix (it's fixed properly in 2.5). Overwriting shipped files should
> never happen, the "rm" may fix the symptoms for some cases, but SCS as
> e.g. bitkeeper will generally not be happy with that kind of behavior.

Thanks Kai, I've closed it pending someone doing a backport from 2.5.

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.