From: Matthew Wilcox <willy@debian.org>
To: Anton Blanchard <anton@samba.org>
Cc: Andrew Morton <akpm@zip.com.au>, linux-scsi@vger.kernel.org
Subject: ppc64-sym2-fix.patch
Date: Wed, 15 Oct 2003 18:13:47 +0100 [thread overview]
Message-ID: <20031015171347.GE16535@parcelfarce.linux.theplanet.co.uk> (raw)
Hi Anton. Looks like you forgot to cc me on this one:
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test7/2.6.0-test7-mm1/broken-out/ppc64-sym2-fix.patch
On first look, you're right. We should do something more sensible if
pci_set_mwi() fails (eg, just report it to the user and carry on without
setting MWI).
But the comment indicates that some revisions of the 896 *require* MWI
to work around chip errata. So I don't particularly want to do that.
The comment in include/asm-ppc64/pci.h seems to indicate that it actually
wouldn't do any harm to return success since the "hardware treats MWI
the same as memory write".
What do you think?
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next reply other threads:[~2003-10-15 17:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-10-15 17:13 Matthew Wilcox [this message]
2003-10-16 0:03 ` ppc64-sym2-fix.patch Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031015171347.GE16535@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=akpm@zip.com.au \
--cc=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox