public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Matthew Wilcox <willy@debian.org>
Cc: Andrew Morton <akpm@zip.com.au>, linux-scsi@vger.kernel.org
Subject: Re: ppc64-sym2-fix.patch
Date: Thu, 16 Oct 2003 10:03:51 +1000	[thread overview]
Message-ID: <20031016000351.GA1135@krispykreme> (raw)
In-Reply-To: <20031015171347.GE16535@parcelfarce.linux.theplanet.co.uk>


Hi,

> Hi Anton.  Looks like you forgot to cc me on this one:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.0-test7/2.6.0-test7-mm1/broken-out/ppc64-sym2-fix.patch

Yeah sorry about that, I did the quick fix and havent revisited it yet.

> The comment in include/asm-ppc64/pci.h seems to indicate that it actually
> wouldn't do any harm to return success since the "hardware treats MWI
> the same as memory write".

I didnt want to because we have certain firmware workarounds that
involve setting smaller cacheline sizes. I was trying to avoid undoing
that.

As Milton here just pointed out, the generic part of the MWI code only
sets the MWI bit (which we should ignore) so we should be good to do
this. I'll test and send the ppc64 specific fix to akpm.

Anton

      reply	other threads:[~2003-10-16  0:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-15 17:13 ppc64-sym2-fix.patch Matthew Wilcox
2003-10-16  0:03 ` Anton Blanchard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031016000351.GA1135@krispykreme \
    --to=anton@samba.org \
    --cc=akpm@zip.com.au \
    --cc=linux-scsi@vger.kernel.org \
    --cc=willy@debian.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox