2.6.0-test9: scsi_dev_flags

2.6.0-test9: scsi_dev_flags

[Russell King]

How are scsi_dev_flags supposed to work?

2.6.0-test9 appears to have an argument with my syquest drive - it
attempts to spin it up without a cartridge being present.  This doesn't
cause any ill effects except a rather long (== about 8 minutes) delay
in booting.

So, I originally added it to the blacklist in scsi_devinfo.c.  This
worked.  I then realised that it was marked as deprecated, in favour
of passing quirks on the command line.

So, I then tried doing exactly that:

	scsi_dev_flags=SyQuest:SQ3270S:4096

4096 being the BLIST flag value corresponding to BLIST_NOSTARTONADD.

However, it appears that 2.6.0-test9 is completely ignoring this, and
it still tries to spin up the drive without cartridge.  The manufacturer
string is "SyQuest" and the model string is "SQ3270S" so I'm don't
believe the command line string is in error.

An additional question comes out from this - if quirk information is now
to be passed on the kernel command line, how are users supposed to work
out the correct command line argument to give for their quirky hardware
given that it doesn't appear to be as trivial as the code suggests?
(IOW, the scsi_dev_flags option appears to be rather undocumented!)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

Re: 2.6.0-test9: scsi_dev_flags

[Patrick Mansfield]

On Sun, Oct 26, 2003 at 02:47:41PM +0000, Russell King wrote:

> So, I then tried doing exactly that:
> 
> 	scsi_dev_flags=SyQuest:SQ3270S:4096

If that is the kernel boot line, you need to prefix the argument with
scsi_mod., i.e. scsi_mod.scsi_dev_flags=, per the module_param
interface(s).

> An additional question comes out from this - if quirk information is now
> to be passed on the kernel command line, how are users supposed to work
> out the correct command line argument to give for their quirky hardware
> given that it doesn't appear to be as trivial as the code suggests?
> (IOW, the scsi_dev_flags option appears to be rather undocumented!)

There is a bit in Documentation/kernel-parameters.txt, but there should be
more documentation added somewhere. Also the integer value can be hex
(0x1000).

-- Patrick Mansfield

Re: 2.6.0-test9: scsi_dev_flags

[Russell King]

On Sun, Oct 26, 2003 at 08:38:50AM -0800, Patrick Mansfield wrote:
> On Sun, Oct 26, 2003 at 02:47:41PM +0000, Russell King wrote:
> 
> > So, I then tried doing exactly that:
> > 
> > 	scsi_dev_flags=SyQuest:SQ3270S:4096
> 
> If that is the kernel boot line, you need to prefix the argument with
> scsi_mod., i.e. scsi_mod.scsi_dev_flags=, per the module_param
> interface(s).
> 
> > An additional question comes out from this - if quirk information is now
> > to be passed on the kernel command line, how are users supposed to work
> > out the correct command line argument to give for their quirky hardware
> > given that it doesn't appear to be as trivial as the code suggests?
> > (IOW, the scsi_dev_flags option appears to be rather undocumented!)
> 
> There is a bit in Documentation/kernel-parameters.txt, but there should be
> more documentation added somewhere. Also the integer value can be hex
> (0x1000).

Ok, I've tried scsi_mod.scsi_dev_flags= and the kernel whinges:

Unknown boot option `scsi_mod.scsi_dev_flags=SyQuest:SQ3270S:4096': ignoring

and it still wants to spin up the drive (I ended up allowing it during
the first spinup attempt):

sda: Spinning up disk...................ready
SCSI device sda: 524288 512-byte hdwr sectors (268 MB)
sda: Write Protect is off
sda: Mode Sense: 99 00 00 08
SCSI device sda: drive cache: write back
 sda: sda1 sda2
Attached scsi removable disk sda at scsi0, channel 0, id 2, lun 0
Attached scsi generic sg0 at scsi0, channel 0, id 1, lun 0,  type 1
Attached scsi generic sg1 at scsi0, channel 0, id 2, lun 0,  type 0

Note that unlike my recent mail to linux-scsi, this time it didn't try
to add the same partitions multiple times.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

Re: 2.6.0-test9: scsi_dev_flags

[Patrick Mansfield]

On Sat, Nov 01, 2003 at 01:13:09PM +0000, Russell King wrote:
> Ok, I've tried scsi_mod.scsi_dev_flags= and the kernel whinges:
> 
> Unknown boot option `scsi_mod.scsi_dev_flags=SyQuest:SQ3270S:4096': ignoring

Russel -

Sorry I got that wrong, it is scsi_mod.dev_flags.

Does the drive work fine with 2.4?

-- Patrick Mansfield