* Re: IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2)
[not found] <200312311132.hBVBWcg6008411@cherrypit.pdx.osdl.net>
@ 2003-12-31 12:00 ` Andrew Morton
2003-12-31 12:06 ` Christoph Hellwig
2003-12-31 12:08 ` Christoph Hellwig
0 siblings, 2 replies; 3+ messages in thread
From: Andrew Morton @ 2003-12-31 12:00 UTC (permalink / raw)
To: John Cherry; +Cc: linux-scsi, Christoph Hellwig
John Cherry <cherry@osdl.org> wrote:
>
> drivers/scsi/aacraid/aachba.c:1409: warning: `flag' might be used uninitialized in this function
> drivers/scsi/eata_generic.h:84:1: warning: "TIMEOUT" redefined
> drivers/scsi/inia100.c:421: warning: `pHCB' might be used uninitialized in this function
> include/scsi/scsi.h:305:1: warning: this is the location of the previous definition
err, yes. The inia100.c one is 100% deadly.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2)
2003-12-31 12:00 ` IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2) Andrew Morton
@ 2003-12-31 12:06 ` Christoph Hellwig
2003-12-31 12:08 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2003-12-31 12:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: John Cherry, linux-scsi, Christoph Hellwig
On Wed, Dec 31, 2003 at 04:00:47AM -0800, Andrew Morton wrote:
> John Cherry <cherry@osdl.org> wrote:
> >
> > drivers/scsi/aacraid/aachba.c:1409: warning: `flag' might be used uninitialized in this function
> > drivers/scsi/eata_generic.h:84:1: warning: "TIMEOUT" redefined
> > drivers/scsi/inia100.c:421: warning: `pHCB' might be used uninitialized in this function
> > include/scsi/scsi.h:305:1: warning: this is the location of the previous definition
>
> err, yes. The inia100.c one is 100% deadly.
Eek, how did that update make mainline? I just posted it to linux-scsi
looking for a tester. Please back the change out for now.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2)
2003-12-31 12:00 ` IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2) Andrew Morton
2003-12-31 12:06 ` Christoph Hellwig
@ 2003-12-31 12:08 ` Christoph Hellwig
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2003-12-31 12:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: John Cherry, linux-scsi, Christoph Hellwig
On Wed, Dec 31, 2003 at 04:00:47AM -0800, Andrew Morton wrote:
> John Cherry <cherry@osdl.org> wrote:
> >
> > drivers/scsi/aacraid/aachba.c:1409: warning: `flag' might be used uninitialized in this function
hmm, I don't get that warning, but I guess some gcc versions aren't
smart enough to figure out that the four values we handle are the only
possible one, "fix" below:
--- 1.21/drivers/scsi/aacraid/aachba.c Wed Nov 19 19:36:23 2003
+++ edited/drivers/scsi/aacraid/aachba.c Wed Dec 31 14:06:40 2003
@@ -1427,6 +1427,7 @@
flag = SRB_DataIn;
break;
case DMA_NONE:
+ default: /* shuts up some versions of gcc */
flag = SRB_NoDataXfer;
break;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2003-12-31 12:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200312311132.hBVBWcg6008411@cherrypit.pdx.osdl.net>
2003-12-31 12:00 ` IA32 (2.6.1 - 2003-12-30.22.30) - 4 New warnings (gcc 3.2.2) Andrew Morton
2003-12-31 12:06 ` Christoph Hellwig
2003-12-31 12:08 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox