From: Adrian Bunk <bunk@fs.tum.de>
To: Jesper Juhl <juhl-lkml@dif.dk>
Cc: Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Oliver Neukum <oliver@neukum.name>, Ali Akcaagac <aliakc@web.de>,
Jamie Lenehan <lenehan@twibble.org>
Subject: Re: [PATCH] fix gcc 3.4 inlining errors in drivers/scsi/dc395x.c
Date: Sun, 1 Aug 2004 16:15:41 +0200 [thread overview]
Message-ID: <20040801141541.GO2746@fs.tum.de> (raw)
In-Reply-To: <Pine.LNX.4.60.0408011355080.2535@dragon.hygekrogen.localhost>
On Sun, Aug 01, 2004 at 02:02:50PM +0200, Jesper Juhl wrote:
>
> drivers/scsi/dc395x.c fails to build in 2.6.8-rc2-mm1 with gcc 3.4.0 with
> the following errors :
>
> drivers/scsi/dc395x.c: In function `dc395x_handle_interrupt':
> drivers/scsi/dc395x.c:388: sorry, unimplemented: inlining failed in call to 'enable_msgout_abort': function body not available
> drivers/scsi/dc395x.c:1740: sorry, unimplemented: called from here
>
> drivers/scsi/dc395x.c: In function `msgin_set_async':
> drivers/scsi/dc395x.c:394: sorry, unimplemented: inlining failed in call to 'set_xfer_rate': function body not available
> drivers/scsi/dc395x.c:2677: sorry, unimplemented: called from here
>
> The patch below fixes the build by un-inlining the functions (an
> alternative would be to rework the file so the functions move before their
> first use). As for 'set_xfer_rate' the function itself was not declared
> inline, only the prototype.
>...
Jamie Lenehan already ACK'ed a similar patch I sent two weeks ago which
moves enable_msgout_abort instead of un-inlining it.
Both approaches are feasible, it's up to the maintainers to decide which
one is better in this case.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-08-01 14:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-01 12:02 [PATCH] fix gcc 3.4 inlining errors in drivers/scsi/dc395x.c Jesper Juhl
2004-08-01 14:15 ` Adrian Bunk [this message]
2004-08-01 14:45 ` Jesper Juhl
2004-08-01 14:57 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040801141541.GO2746@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=akpm@osdl.org \
--cc=aliakc@web.de \
--cc=juhl-lkml@dif.dk \
--cc=lenehan@twibble.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oliver@neukum.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox