From: Anton Blanchard <anton@samba.org>
To: linux-scsi@vger.kernel.org
Subject: sym2 oops in 2.6.9-rc2-BK
Date: Tue, 28 Sep 2004 23:58:26 +1000 [thread overview]
Message-ID: <20040928135826.GA3373@krispykreme.ozlabs.ibm.com> (raw)
Hi,
Ive got a 2.6.9-rc2-bk tree from about September 16 which exploded in
sym_prepare_nego. It turns out sdev is NULL, and scsi_device_dt(sdev)
causes the trouble.
A few lines above there is a check for sdev != NULL, so assuming it is
valid to be NULL add a check before scsi_device_dt() too.
Anton
Signed-off-by: Anton Blanchard <anton@samba.org>
diff -puN drivers/scsi/sym53c8xx_2/sym_hipd.c~fix-sym2 drivers/scsi/sym53c8xx_2/sym_hipd.c
--- gr_work/drivers/scsi/sym53c8xx_2/sym_hipd.c~fix-sym2 2004-09-28 03:03:26.493627814 -0500
+++ gr_work-anton/drivers/scsi/sym53c8xx_2/sym_hipd.c 2004-09-28 03:03:50.247458823 -0500
@@ -1550,7 +1550,7 @@ static int sym_prepare_nego(hcb_p np, cc
/*
* negotiate using PPR ?
*/
- if (scsi_device_dt(sdev)) {
+ if (sdev && scsi_device_dt(sdev)) {
nego = NS_PPR;
} else {
/*
next reply other threads:[~2004-09-28 13:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 13:58 Anton Blanchard [this message]
2004-09-28 14:21 ` sym2 oops in 2.6.9-rc2-BK Anton Blanchard
2004-09-28 15:17 ` Matthew Wilcox
2004-09-28 14:56 ` Matthew Wilcox
2004-09-28 15:25 ` Anton Blanchard
2004-09-28 15:38 ` James Bottomley
2004-09-30 13:05 ` Anton Blanchard
2004-09-30 13:52 ` James Bottomley
2004-09-30 14:05 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928135826.GA3373@krispykreme.ozlabs.ibm.com \
--to=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox