From: Matthew Wilcox <matthew@wil.cx>
To: Anton Blanchard <anton@samba.org>
Cc: linux-scsi@vger.kernel.org
Subject: Re: sym2 oops in 2.6.9-rc2-BK
Date: Tue, 28 Sep 2004 15:56:38 +0100 [thread overview]
Message-ID: <20040928145638.GY16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20040928135826.GA3373@krispykreme.ozlabs.ibm.com>
On Tue, Sep 28, 2004 at 11:58:26PM +1000, Anton Blanchard wrote:
> Ive got a 2.6.9-rc2-bk tree from about September 16 which exploded in
> sym_prepare_nego. It turns out sdev is NULL, and scsi_device_dt(sdev)
> causes the trouble.
>
> A few lines above there is a check for sdev != NULL, so assuming it is
> valid to be NULL add a check before scsi_device_dt() too.
Yes, this looks like the right solution to me.
Can you tell me what circumstances you see it under, and do you
successfully negotiate 160MB/s with this patch?
--
"Next the statesmen will invent cheap lies, putting the blame upon
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince
himself that the war is just, and will thank God for the better sleep
he enjoys after this process of grotesque self-deception." -- Mark Twain
next prev parent reply other threads:[~2004-09-28 14:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-28 13:58 sym2 oops in 2.6.9-rc2-BK Anton Blanchard
2004-09-28 14:21 ` Anton Blanchard
2004-09-28 15:17 ` Matthew Wilcox
2004-09-28 14:56 ` Matthew Wilcox [this message]
2004-09-28 15:25 ` Anton Blanchard
2004-09-28 15:38 ` James Bottomley
2004-09-30 13:05 ` Anton Blanchard
2004-09-30 13:52 ` James Bottomley
2004-09-30 14:05 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040928145638.GY16153@parcelfarce.linux.theplanet.co.uk \
--to=matthew@wil.cx \
--cc=anton@samba.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox