From: "Randy.Dunlap" <rddunlap@osdl.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Heinzmann@cc-dresden.de, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] sym53c8xx module parameter passing not working (2.5.6)
Date: Fri, 1 Oct 2004 14:28:37 -0700 [thread overview]
Message-ID: <20041001142837.6b2d0031.rddunlap@osdl.org> (raw)
In-Reply-To: <20041001211136.GN16153@parcelfarce.linux.theplanet.co.uk>
On Fri, 1 Oct 2004 22:11:36 +0100 Matthew Wilcox wrote:
| On Fri, Oct 01, 2004 at 05:26:21PM +0200, Heinzmann, Robert wrote:
| > The 2.6 version of sym53c8xx_2 did not read the module command line parameter properly.
| > This was due to a missing call to sym53c8xx_setup().
|
| I don't understand, actually.
|
| #ifndef MODULE
| __setup("sym53c8xx=", sym53c8xx_setup);
| #endif
|
| should cause sym53c8xx_setup to be called.
It should for the non-loadable-module case. I think that Robert
is saying that it doesn't work for the loadable-module case.
I.e., these lines aren't doing what is expected:
#ifdef MODULE
char *sym53c8xx; /* command line passed by insmod */
MODULE_PARM(sym53c8xx, "s");
#endif
--
~Randy
next prev parent reply other threads:[~2004-10-01 21:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-01 15:26 [PATCH] sym53c8xx module parameter passing not working (2.5.6) Heinzmann, Robert
2004-10-01 15:29 ` Christoph Hellwig
2004-10-01 16:55 ` Matthew Wilcox
2004-10-08 1:30 ` Matthew Wilcox
2004-10-08 2:29 ` Rusty Russell
2004-10-08 14:39 ` New-style module parameters in SCSI drivers Matthew Wilcox
2004-10-01 21:11 ` [PATCH] sym53c8xx module parameter passing not working (2.5.6) Matthew Wilcox
2004-10-01 21:28 ` Randy.Dunlap [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-10-01 15:45 Heinzmann, Robert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041001142837.6b2d0031.rddunlap@osdl.org \
--to=rddunlap@osdl.org \
--cc=Heinzmann@cc-dresden.de \
--cc=linux-scsi@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox