public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Christoph Hellwig <hch@infradead.org>,
	"Heinzmann, Robert" <Heinzmann@cc-dresden.de>,
	linux-scsi@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] sym53c8xx module parameter passing not working (2.5.6)
Date: Fri, 8 Oct 2004 02:30:29 +0100	[thread overview]
Message-ID: <20041008013029.GM16153@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20041001165555.GF16153@parcelfarce.linux.theplanet.co.uk>

On Fri, Oct 01, 2004 at 05:55:55PM +0100, Matthew Wilcox wrote:
> On Fri, Oct 01, 2004 at 04:29:39PM +0100, Christoph Hellwig wrote:
> > Given that no one except you noticed the lack of options so far what
> > about moving it to normal parameters instead, aka one option per setting
> > like all non-scsi and resent scsi drivers do?
> 
> I think it's definitely time to make this change.  I'll look at it later
> today.

I have it working ... but there's no way to do a graceful transition.
I had in mind something like:

+       printk(NAME53C8XX "Using old-style setup code.  Please switch to new "
+                       "module param code.\n"
+                       "See Documentation/scsi/sym53c8xx_2.txt for "
+                       "details.\n");
+

to allow people to switch over.  But when I try this, I get:

sym53c8xx: Unknown parameter `hostid'
sym53c8xx: Ignoring new-style parameters in presence of obsolete ones

It'd be nice to be able to use either for a while.  Rusty, is there any
chance of allowing this?

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain

  reply	other threads:[~2004-10-08  1:30 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-01 15:26 [PATCH] sym53c8xx module parameter passing not working (2.5.6) Heinzmann, Robert
2004-10-01 15:29 ` Christoph Hellwig
2004-10-01 16:55   ` Matthew Wilcox
2004-10-08  1:30     ` Matthew Wilcox [this message]
2004-10-08  2:29       ` Rusty Russell
2004-10-08 14:39         ` New-style module parameters in SCSI drivers Matthew Wilcox
2004-10-01 21:11 ` [PATCH] sym53c8xx module parameter passing not working (2.5.6) Matthew Wilcox
2004-10-01 21:28   ` Randy.Dunlap
  -- strict thread matches above, loose matches on Subject: below --
2004-10-01 15:45 Heinzmann, Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20041008013029.GM16153@parcelfarce.linux.theplanet.co.uk \
    --to=matthew@wil.cx \
    --cc=Heinzmann@cc-dresden.de \
    --cc=hch@infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox