Fw: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717

Fw: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717

[Andrew Morton]

Begin forwarded message:

Date: Sun, 21 Nov 2004 06:25:30 -0800
From: bugme-daemon@osdl.org
To: bugme-new@lists.osdl.org
Subject: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717


http://bugme.osdl.org/show_bug.cgi?id=3787

           Summary: Badness in scsi_device_set_state at
                    drivers/scsi/scsi_lib.c:1717
    Kernel Version: 2.6.10-rc2
            Status: NEW
          Severity: high
             Owner: andmike@us.ibm.com
         Submitter: matthias.christian@tiscali.de


Distribution: Arch Linux
Hardware Environment: Pentium4
Software Environment: GlibC 2.3.3, GCC 3.4.3
Problem Description:
usb 2-1: USB disconnect, address 3
/root/atmelwlandriver/objs/usbvnetr/release/callbacks.c: Rx Failed.!
Device atml0 closed
device disconnected
usb 2-1: new full speed USB device using uhci_hcd and address 4
Initializing USB Mass Storage driver...
scsi0 : SCSI emulation for USB Mass Storage devices
usbcore: registered new driver usb-storage
USB Mass Storage support registered.
usb-storage: device found at 4
usb-storage: waiting for device to settle before scanning
  Vendor: Digital   Model: Camera            Rev: 1.00
  Type:   Direct-Access                      ANSI SCSI revision: 00
SCSI device sda: 124160 512-byte hdwr sectors (64 MB)
sda: Write Protect is off
sda: Mode Sense: 00 06 00 00
sda: assuming drive cache: write through
 /dev/scsi/host0/bus0/target0/lun0: p1
Attached scsi removable disk sda at scsi0, channel 0, id 0, lun 0
usb-storage: device scan complete
usb 2-1: USB disconnect, address 4
 target0:0:0: Illegal state transition <NULL>->cancel
Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717
 [<c03baf61>] scsi_device_set_state+0xba/0x13e
 [<c03b5ed6>] scsi_device_cancel+0x2a/0xf3
 [<c03b5ffd>] scsi_device_cancel_cb+0x0/0x1c
 [<c0370a8f>] device_for_each_child+0x3c/0x69
 [<c03b604a>] scsi_host_cancel+0x31/0xbc
 [<c03b5ffd>] scsi_device_cancel_cb+0x0/0x1c
 [<c03029a4>] kobject_put+0x1e/0x22
 [<c03029a4>] kobject_put+0x1e/0x22
 [<c030297c>] kobject_release+0x0/0xa
 [<c03bd41a>] scsi_remove_device+0x7d/0xaf
 [<c03bc657>] scsi_forget_host+0x39/0x58
 [<c03b60f5>] scsi_remove_host+0x20/0x7d
 [<d91f4000>] storage_disconnect+0x83/0x98 [usb_storage]
 [<d8fe2104>] usb_unbind_interface+0x7c/0x7e [usbcore]
 [<c03718ab>] device_release_driver+0x7f/0x81
 [<c0371afc>] bus_remove_device+0x65/0xa7
 [<c03709e7>] device_del+0x59/0xa8
 [<d8fe9b18>] usb_disable_device+0x77/0xea [usbcore]
 [<d8fe4477>] usb_disconnect+0xb8/0x162 [usbcore]
 [<d8fe5ee8>] hub_port_connect_change+0x339/0x42d [usbcore]
 [<d8fe3135>] clear_port_feature+0x58/0x5c [usbcore]
 [<d8fe618c>] hub_events+0x1b0/0x3b3 [usbcore]
 [<d8fe63c6>] hub_thread+0x37/0x105 [usbcore]
 [<c0132a86>] autoremove_wake_function+0x0/0x57
 [<c0103042>] ret_from_fork+0x6/0x14
 [<c0132a86>] autoremove_wake_function+0x0/0x57
 [<d8fe638f>] hub_thread+0x0/0x105 [usbcore]
 [<c010128d>] kernel_thread_helper+0x5/0xb

Steps to reproduce:
I pluged-in my Digital Camera, I copied some files, I pluged it out und pluged
it in a second time.

------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.

Re: Fw: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717

[Christian Iversen]

On Sunday 21 November 2004 21:38, Andrew Morton wrote:
> Begin forwarded message:

Andrew, please look at http://bugme.osdl.org/show_bug.cgi?id=3761. I reported 
the same bug, and have some comments from the SCSI people. James Bottomley 
helped me a lot, and has the patch that supposedly fixes it (I haven't had a 
chance to try it yet). The patch that is included in my bug report worked 
well for me as far as I couldn't reproduce a crash anymore. Unfortunately, 
because of the USB subsystem is broken in 2.6.10-rc* it's no good for my 
server. (I'm still using 2.6.5.)

That's on vanilla kernels, but I'm going to see if -mm is better, soon.

-- 
Regards,
Christian Iversen

Re: Fw: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717

[James Bottomley]

On Sun, 2004-11-21 at 14:38, Andrew Morton wrote:
> Begin forwarded message:
> 
> Date: Sun, 21 Nov 2004 06:25:30 -0800
> From: bugme-daemon@osdl.org
> To: bugme-new@lists.osdl.org
> Subject: [Bugme-new] [Bug 3787] New: Badness in scsi_device_set_state at drivers/scsi/scsi_lib.c:1717

The fix for this should be upstream already (sent in the last lot of -rc
fixes):

ChangeSet@1.2184, 2004-11-18 17:00:19-06:00, jejb@mulgrave.(none)
  SCSI: fix USB forced remove oops

I'm afraid this is my fault ... I created the fix some time ago and just
forgot to apply (or rather thought I already had applied) it.

Anyway, this is a warning to everyone ... just because I come up with a
fix for a problem, it doesn't mean I'll remember to apply it, so if you
care about it ... remind me!

James