From: Christoph Hellwig <hch@infradead.org>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] clean up drivers/scsi/scsi.h
Date: Mon, 14 Feb 2005 11:09:58 +0000 [thread overview]
Message-ID: <20050214110958.GB2367@infradead.org> (raw)
In-Reply-To: <200502141157.30447@bilbo.math.uni-mannheim.de>
On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote:
> Hi,
>
> this patch removes some useless struct declarations from drivers/scsi/scsi.h.
> All this structs are already defined in the header files included above
> except Scsi_Host, for which we now directly include <scsi/scsi_host.h>
No, this is totally wrong. If you only use pointers to structs always
use forward declarations instead of pulling in a full header.
next prev parent reply other threads:[~2005-02-14 11:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 10:57 [PATCH] clean up drivers/scsi/scsi.h Rolf Eike Beer
2005-02-14 11:09 ` Christoph Hellwig [this message]
2005-02-14 11:32 ` Rolf Eike Beer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050214110958.GB2367@infradead.org \
--to=hch@infradead.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox