From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] clean up drivers/scsi/scsi.h
Date: Mon, 14 Feb 2005 12:32:29 +0100 [thread overview]
Message-ID: <200502141232.30212@bilbo.math.uni-mannheim.de> (raw)
In-Reply-To: <20050214110958.GB2367@infradead.org>
Am Montag, 14. Februar 2005 12:09 schrieb Christoph Hellwig:
> On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote:
> > Hi,
> >
> > this patch removes some useless struct declarations from
> > drivers/scsi/scsi.h. All this structs are already defined in the header
> > files included above except Scsi_Host, for which we now directly include
> > <scsi/scsi_host.h>
>
> No, this is totally wrong. If you only use pointers to structs always
> use forward declarations instead of pulling in a full header.
Ok, this time without include scsi/scsi_host.h. The rest remains untouched,
"struct Scsi_Host;" is also in scsi/scsi_device.h. The header files for all
other structs are already included so no need do declare them again.
Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de>
--- linux-2.6.10/drivers/scsi/scsi.h 2004-12-24 22:34:27.000000000 +0100
+++ linux-2.6.10/drivers/scsi/scsi.h-new 2005-02-14 11:45:54.000000000 +0100
@@ -40,12 +40,6 @@
#define FALSE 0
#endif
-struct Scsi_Host;
-struct scsi_cmnd;
-struct scsi_device;
-struct scsi_target;
-struct scatterlist;
-
/*
* Legacy dma direction interfaces.
*
prev parent reply other threads:[~2005-02-14 11:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-02-14 10:57 [PATCH] clean up drivers/scsi/scsi.h Rolf Eike Beer
2005-02-14 11:09 ` Christoph Hellwig
2005-02-14 11:32 ` Rolf Eike Beer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200502141232.30212@bilbo.math.uni-mannheim.de \
--to=eike-kernel@sf-tec.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox