From: Olaf Hering <olh@suse.de>
To: Andrew Vasquez <andrew.vasquez@qlogic.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH] uninline exported ata_host_intr
Date: Fri, 5 Aug 2005 19:39:18 +0200 [thread overview]
Message-ID: <20050805173918.GA6333@suse.de> (raw)
In-Reply-To: <20050805173003.GU13374@plap.qlogic.org>
On Fri, Aug 05, Andrew Vasquez wrote:
> Confused, you found a reference to ata_host_intr() in qla4xxx
> (QLogic's iSCSI driver)? This is in a SLES kernel correct, and not in
> mainline?
No, qla4xxx called extern inline function in foo.c from bar.c. gcc4 doesnt like
that because the 'function body is not available'. I found no external users of
ata_host_intr, maybe it happens there as well.
If there is a significant performance boost with these inline constructs,
thats just fine with me as long as it compiles.
next prev parent reply other threads:[~2005-08-05 17:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 17:03 [PATCH] uninline exported ata_host_intr Olaf Hering
2005-08-05 17:10 ` Jeff Garzik
2005-08-05 17:15 ` Olaf Hering
2005-08-05 17:30 ` Andrew Vasquez
2005-08-05 17:39 ` Olaf Hering [this message]
2005-08-05 17:44 ` Jeff Garzik
2005-08-05 17:37 ` Doug Maxey
2005-08-05 20:10 ` Andrew Morton
2005-08-05 20:49 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050805173918.GA6333@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=andrew.vasquez@qlogic.com \
--cc=jgarzik@pobox.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox