From: Jeff Garzik <jgarzik@pobox.com>
To: Olaf Hering <olh@suse.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] uninline exported ata_host_intr
Date: Fri, 05 Aug 2005 13:44:34 -0400 [thread overview]
Message-ID: <42F3A582.8050800@pobox.com> (raw)
In-Reply-To: <20050805171500.GA6161@suse.de>
Olaf Hering wrote:
> On Fri, Aug 05, Jeff Garzik wrote:
>
>
>>When I wrote this, the compiler did what I expected: it inlined the
>>local copy, and exported a copy for external modules to call.
>
>
> so you have the code twice? how clever...
This is one of the key hot paths in the driver.
Considering that drivers either call one copy, or the other, the
tradeoff is minor overall code size increase for performance gains.
This is a typical tradeoff in hot paths.
The code stays until you prove otherwise...
Jeff
next prev parent reply other threads:[~2005-08-05 17:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-05 17:03 [PATCH] uninline exported ata_host_intr Olaf Hering
2005-08-05 17:10 ` Jeff Garzik
2005-08-05 17:15 ` Olaf Hering
2005-08-05 17:30 ` Andrew Vasquez
2005-08-05 17:39 ` Olaf Hering
2005-08-05 17:44 ` Jeff Garzik [this message]
2005-08-05 17:37 ` Doug Maxey
2005-08-05 20:10 ` Andrew Morton
2005-08-05 20:49 ` Doug Maxey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42F3A582.8050800@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=olh@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox