Linux SCSI subsystem development
 help / color / mirror / Atom feed
* [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
       [not found]     ` <Pine.LNX.4.58.0510190300010.20634@localhost.localdomain>
@ 2005-10-19  7:54       ` Steven Rostedt
  2005-10-19 11:31         ` Christoph Hellwig
  0 siblings, 1 reply; 7+ messages in thread
From: Steven Rostedt @ 2005-10-19  7:54 UTC (permalink / raw)
  To: Lee Revell
  Cc: Mark Knecht, linux-kernel, Ingo Molnar, rmk, Linus Torvalds,
	Andrew Morton, andmike, linux-scsi


Found in the -rt patch set.  The scsi_error thread likely will be in the
TASK_INTERRUPTIBLE state upon exit.  This patch fixes this bug.

-- Steve

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.14-rc4/drivers/scsi/scsi_error.c
===================================================================
--- linux-2.6.14-rc4.orig/drivers/scsi/scsi_error.c	2005-10-19 03:37:55.000000000 -0400
+++ linux-2.6.14-rc4/drivers/scsi/scsi_error.c	2005-10-19 03:38:59.000000000 -0400
@@ -1645,6 +1645,12 @@
 		set_current_state(TASK_INTERRUPTIBLE);
 	}

+	/*
+	 * There's a good chance that the loop will exit in the
+	 * TASK_INTERRUPTIBLE state.
+	 */
+	__set_current_state(TASK_RUNNING);
+
 	SCSI_LOG_ERROR_RECOVERY(1, printk("Error handler scsi_eh_%d"
 					  " exiting\n",shost->host_no));



^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19  7:54       ` [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state Steven Rostedt
@ 2005-10-19 11:31         ` Christoph Hellwig
  2005-10-19 11:51           ` Steven Rostedt
  0 siblings, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2005-10-19 11:31 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Lee Revell, Mark Knecht, linux-kernel, Ingo Molnar, rmk,
	Linus Torvalds, Andrew Morton, andmike, linux-scsi

> +	/*
> +	 * There's a good chance that the loop will exit in the
> +	 * TASK_INTERRUPTIBLE state.
> +	 */
> +	__set_current_state(TASK_RUNNING);

no need to comment the obvious.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19 11:31         ` Christoph Hellwig
@ 2005-10-19 11:51           ` Steven Rostedt
  2005-10-19 11:54             ` Christoph Hellwig
  2005-10-19 11:56             ` Ingo Molnar
  0 siblings, 2 replies; 7+ messages in thread
From: Steven Rostedt @ 2005-10-19 11:51 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Lee Revell, Mark Knecht, linux-kernel, Ingo Molnar, rmk,
	Linus Torvalds, Andrew Morton, andmike, linux-scsi


On Wed, 19 Oct 2005, Christoph Hellwig wrote:

> > +	/*
> > +	 * There's a good chance that the loop will exit in the
> > +	 * TASK_INTERRUPTIBLE state.
> > +	 */
> > +	__set_current_state(TASK_RUNNING);
>
> no need to comment the obvious.
>

So, should I resend the patch without the comment?

-- Steve


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19 11:51           ` Steven Rostedt
@ 2005-10-19 11:54             ` Christoph Hellwig
  2005-10-19 12:22               ` Steven Rostedt
  2005-10-19 11:56             ` Ingo Molnar
  1 sibling, 1 reply; 7+ messages in thread
From: Christoph Hellwig @ 2005-10-19 11:54 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Christoph Hellwig, Lee Revell, Mark Knecht, linux-kernel,
	Ingo Molnar, rmk, Linus Torvalds, Andrew Morton, andmike,
	linux-scsi

On Wed, Oct 19, 2005 at 07:51:47AM -0400, Steven Rostedt wrote:
> So, should I resend the patch without the comment?

yes, please ;-)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19 11:51           ` Steven Rostedt
  2005-10-19 11:54             ` Christoph Hellwig
@ 2005-10-19 11:56             ` Ingo Molnar
  2005-10-19 11:59               ` Christoph Hellwig
  1 sibling, 1 reply; 7+ messages in thread
From: Ingo Molnar @ 2005-10-19 11:56 UTC (permalink / raw)
  To: Steven Rostedt
  Cc: Christoph Hellwig, Lee Revell, Mark Knecht, linux-kernel, rmk,
	Linus Torvalds, Andrew Morton, andmike, linux-scsi


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 19 Oct 2005, Christoph Hellwig wrote:
> 
> > > +	/*
> > > +	 * There's a good chance that the loop will exit in the
> > > +	 * TASK_INTERRUPTIBLE state.
> > > +	 */
> > > +	__set_current_state(TASK_RUNNING);
> >
> > no need to comment the obvious.
> 
> So, should I resend the patch without the comment?

i guess so. OTOH, if it was so obvious, why did it stay unfixed for so 
long ;-)

	Ingo

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19 11:56             ` Ingo Molnar
@ 2005-10-19 11:59               ` Christoph Hellwig
  0 siblings, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2005-10-19 11:59 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Steven Rostedt, Christoph Hellwig, Lee Revell, Mark Knecht,
	linux-kernel, rmk, Linus Torvalds, Andrew Morton, andmike,
	linux-scsi

On Wed, Oct 19, 2005 at 01:56:53PM +0200, Ingo Molnar wrote:
> > So, should I resend the patch without the comment?
> 
> i guess so. OTOH, if it was so obvious, why did it stay unfixed for so 
> long ;-)

 a) the code is pretty new
 b) this isn't a serious problem for kernels without your preempt-rt patch


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
  2005-10-19 11:54             ` Christoph Hellwig
@ 2005-10-19 12:22               ` Steven Rostedt
  0 siblings, 0 replies; 7+ messages in thread
From: Steven Rostedt @ 2005-10-19 12:22 UTC (permalink / raw)
  To: Christoph Hellwig
  Cc: Lee Revell, Mark Knecht, linux-kernel, Ingo Molnar, rmk,
	Linus Torvalds, Andrew Morton, andmike, linux-scsi


Once again here's the patch.

Andrew, can you pull my previous one in favor of this one

I'm one of the rare breeds of programmers that over document, at least I
didn't comment "x equals a plus b" for "x = a + b" but I'm sure Christoph
would say that I was pretty close ;-)

Description:

Found in the -rt patch set.  The scsi_error thread likely will be in the
TASK_INTERRUPTIBLE state upon exit.  This patch fixes this bug.

Ingo,

I take it that you don't care about the comment for RT.

-- Steve

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>

Index: linux-2.6.14-rc4/drivers/scsi/scsi_error.c
===================================================================
--- linux-2.6.14-rc4.orig/drivers/scsi/scsi_error.c	2005-10-19 03:37:55.000000000 -0400
+++ linux-2.6.14-rc4/drivers/scsi/scsi_error.c	2005-10-19 08:10:23.000000000 -0400
@@ -1645,6 +1645,8 @@
 		set_current_state(TASK_INTERRUPTIBLE);
 	}

+	__set_current_state(TASK_RUNNING);
+
 	SCSI_LOG_ERROR_RECOVERY(1, printk("Error handler scsi_eh_%d"
 					  " exiting\n",shost->host_no));


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2005-10-19 12:22 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <5bdc1c8b0510181402o2d9badb0sd18012cf7ff2a329@mail.gmail.com>
     [not found] ` <1129693423.8910.54.camel@mindpipe>
     [not found]   ` <1129695564.8910.64.camel@mindpipe>
     [not found]     ` <Pine.LNX.4.58.0510190300010.20634@localhost.localdomain>
2005-10-19  7:54       ` [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state Steven Rostedt
2005-10-19 11:31         ` Christoph Hellwig
2005-10-19 11:51           ` Steven Rostedt
2005-10-19 11:54             ` Christoph Hellwig
2005-10-19 12:22               ` Steven Rostedt
2005-10-19 11:56             ` Ingo Molnar
2005-10-19 11:59               ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox