From: Andrew Morton <akpm@linux-foundation.org>
To: mike.miller@hp.com
Cc: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>,
jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, gregkh@novell.com
Subject: Re: [Patch 2/2] cciss: add reboot notifier support to driver
Date: Wed, 21 Feb 2007 19:17:59 -0800 [thread overview]
Message-ID: <20070221191759.190e1a18.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070221211251.GB2672@beardog.cca.cpqcorp.net>
On Wed, 21 Feb 2007 15:12:51 -0600 "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
> @@ -3293,6 +3327,12 @@ #endif
> ((hba[i]->nr_cmds + BITS_PER_LONG -
> 1) / BITS_PER_LONG) * sizeof(unsigned long));
>
> + if (notify_count == 0) {
> + register_reboot_notifier(&cciss_notifier);
> + notify_count=1;
> + }
> +
> +
> #ifdef CCISS_DEBUG
> printk(KERN_DEBUG "Scanning for drives on controller cciss%d\n", i);
> #endif /* CCISS_DEBUG */
> @@ -3500,6 +3540,7 @@ static void __exit cciss_cleanup(void)
> int i;
>
> pci_unregister_driver(&cciss_pci_driver);
> + unregister_reboot_notifier(&cciss_notifier);
Should we check that it was registered before going and unregistering
it? ie: do `modprobe cciss' on a machine which has no cciss hardware,
then do rmmod...
next prev parent reply other threads:[~2007-02-22 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 21:12 [Patch 2/2] cciss: add reboot notifier support to driver Mike Miller (OS Dev)
2007-02-22 3:17 ` Andrew Morton [this message]
2007-02-22 3:33 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070221191759.190e1a18.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@novell.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox