From: Christoph Hellwig <hch@infradead.org>
To: mike.miller@hp.com
Cc: jens.axboe@oracle.com, akpm@osdl.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
gregkh@novell.com
Subject: Re: [Patch 2/2] cciss: add reboot notifier support to driver
Date: Thu, 22 Feb 2007 03:33:19 +0000 [thread overview]
Message-ID: <20070222033319.GA7493@infradead.org> (raw)
In-Reply-To: <20070221211251.GB2672@beardog.cca.cpqcorp.net>
On Wed, Feb 21, 2007 at 03:12:51PM -0600, Mike Miller (OS Dev) wrote:
> Patch 2/2
>
> This patch adds reboot_notifier support to cciss. Changes in firmware make this patch
> essential. Without this patch there may be valid data left in the controller's battery
> backed write cache (BBWC) on shutdown. We found out the hard way that the kernel does
> not call our cleanup routines on shutdown or reboot. It seems that only rmmod calls
> the cleanup.
> Please consider this for inclusion.
>
NAK. This should be using the shutdown method in struct pci_driver instead.
I really wish we wouldn't export the reboot_notifier so people don't repeat
this mistake over and over again..
prev parent reply other threads:[~2007-02-22 3:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-21 21:12 [Patch 2/2] cciss: add reboot notifier support to driver Mike Miller (OS Dev)
2007-02-22 3:17 ` Andrew Morton
2007-02-22 3:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070222033319.GA7493@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=gregkh@novell.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox