s390 error: implicit declaration of function sg_dma_len

s390 error: implicit declaration of function sg_dma_len

[Olaf Hering]

Current Linus tree does not compile on s390 because esp_scsi references
unavailable functions.

/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_map_dma':
/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:338: error: implicit declaration of function `sg_dma_len'
/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_cur_dma_addr':
/dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:357: error: implicit declaration of function `sg_dma_address'

Re: s390 error: implicit declaration of function sg_dma_len

[David Miller]

From: Olaf Hering <olaf@aepfle.de>
Date: Fri, 25 May 2007 10:22:38 +0200

> Current Linus tree does not compile on s390 because esp_scsi references
> unavailable functions.

I have a fix for this pending in my sparc-2.6 tree which I'll
send to Linus tomorrow, thanks for the report.

[PATCH] s390 error: implicit declaration of function sg_dma_len

[Hannes Reinecke]

Olaf Hering wrote:
> Current Linus tree does not compile on s390 because esp_scsi references
> unavailable functions.
> 
> /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_map_dma':
> /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:338: error: implicit declaration of function `sg_dma_len'
> /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c: In function `esp_cur_dma_addr':
> /dev/shm/R/linux-2.6.21/drivers/scsi/esp_scsi.c:357: error: implicit declaration of function `sg_dma_address'
> 
Hmm. Try this:

diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index d28c14e..4909863 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -1755,7 +1755,7 @@ config SUN3X_ESP

 config SCSI_ESP_CORE
        tristate "ESP Scsi Driver Core"
-       depends on SCSI
+       depends on SCSI && !S390
        select SCSI_SPI_ATTRS
        help
          This is a core driver for NCR53c9x based scsi chipsets,

James, please apply. ESP cards simply don't fit in a mainframe :-)

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Markus Rex, HRB 16746 (AG Nürnberg)
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] s390 error: implicit declaration of function sg_dma_len

[David Miller]

From: Hannes Reinecke <hare@suse.de>
Date: Fri, 25 May 2007 11:08:08 +0200

> James, please apply. ESP cards simply don't fit in a mainframe :-)

No James, please don't, I have a patch in my sparc-2.6 queue which
will fix this already, and in a different way.

Re: [PATCH] s390 error: implicit declaration of function sg_dma_len

[James Bottomley]

On Fri, 2007-05-25 at 02:13 -0700, David Miller wrote:
> From: Hannes Reinecke <hare@suse.de>
> Date: Fri, 25 May 2007 11:08:08 +0200
> 
> > James, please apply. ESP cards simply don't fit in a mainframe :-)
> 
> No James, please don't, I have a patch in my sparc-2.6 queue which
> will fix this already, and in a different way.

OK, I won't ... but we're growing users of this base driver now, like
this one:

http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=352e921f0dd42f79652cdb50dd91122d068d7209

Could you share the updates you're planning with linux-scsi, just so we
don't run into problems?

Thanks,

James

Re: [PATCH] s390 error: implicit declaration of function sg_dma_len

[David Miller]

From: James Bottomley <James.Bottomley@SteelEye.com>
Date: Fri, 25 May 2007 08:47:38 -0500

> OK, I won't ... but we're growing users of this base driver now, like
> this one:
> 
> http://git.kernel.org/?p=linux/kernel/git/jejb/scsi-misc-2.6.git;a=commit;h=352e921f0dd42f79652cdb50dd91122d068d7209
> 
> Could you share the updates you're planning with linux-scsi, just so we
> don't run into problems?

Only the driver front-end Kconfg's will exist, which will
properly check for things like platform and bus type
dependencies, and the Makefile goes:

obj-$(FOO_ESP)	+= esp_core.o foo_esp.o

Re: [PATCH] s390 error: implicit declaration of function sg_dma_len

[David Miller]

From: Hannes Reinecke <hare@suse.de>
Date: Fri, 25 May 2007 11:08:08 +0200

> -       depends on SCSI
> +       depends on SCSI && !S390

And for the record, the correct test would be HAS_DMA not
!S390.