public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Thibaut VARENE <T-Bone@parisc-linux.org>
Cc: Grant Grundler <grundler@parisc-linux.org>,
	James Bottomley <James.Bottomley@steeleye.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] add help to WAIT_SCAN option
Date: Sat, 26 May 2007 18:05:20 -0600	[thread overview]
Message-ID: <20070527000520.GQ5798@parisc-linux.org> (raw)
In-Reply-To: <7d01f9f00705261610q7d2d8bf8m777362802f8eb090@mail.gmail.com>

On Sun, May 27, 2007 at 01:10:36AM +0200, Thibaut VARENE wrote:
> >diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
> 
> Works For Me (tm)

Great, thanks!

James, can you put this patch into your tree?

-----

When all scsi drivers are built-in, we need to automatically call
scsi_complete_async_scans before we need to find the root filesystem.
This used to be done by compiling scsi_wait_scan into the kernel, but
that doesn't work when some scsi drivers are modular.  Instead, just add
a late_initcall() when the SCSI subsystem is built-in.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index a67f315..2653a06 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -184,6 +184,11 @@ int scsi_complete_async_scans(void)
 /* Only exported for the benefit of scsi_wait_scan */
 EXPORT_SYMBOL_GPL(scsi_complete_async_scans);
 
+/* If everything's built in, we need to wait for everything to scan */
+#ifndef MODULE
+late_initcall(scsi_complete_async_scans);
+#endif
+
 /**
  * scsi_unlock_floptical - unlock device via a special MODE SENSE command
  * @sdev:	scsi device to send command to

      reply	other threads:[~2007-05-27  0:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-26 19:11 [PATCH] add help to WAIT_SCAN option Grant Grundler
2007-05-26 19:50 ` James Bottomley
2007-05-27  0:06   ` Grant Grundler
2007-05-27  0:15     ` James Bottomley
2007-05-27  0:27       ` Matthew Wilcox
2007-05-27  0:29         ` James Bottomley
2007-05-27  0:33           ` Matthew Wilcox
2007-05-27  0:53             ` Grant Grundler
2007-05-26 20:44 ` Matthew Wilcox
2007-05-26 22:25   ` Thibaut VARENE
2007-05-26 23:03     ` Matthew Wilcox
2007-05-26 23:10       ` Thibaut VARENE
2007-05-27  0:05         ` Matthew Wilcox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070527000520.GQ5798@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=James.Bottomley@steeleye.com \
    --cc=T-Bone@parisc-linux.org \
    --cc=grundler@parisc-linux.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox