From: Matthew Wilcox <matthew@wil.cx>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Grant Grundler <grundler@parisc-linux.org>,
linux-scsi@vger.kernel.org,
Thibaut VARENE <T-Bone@parisc-linux.org>
Subject: Re: [PATCH] add help to WAIT_SCAN option
Date: Sat, 26 May 2007 18:27:10 -0600 [thread overview]
Message-ID: <20070527002710.GR5798@parisc-linux.org> (raw)
In-Reply-To: <1180224943.3712.84.camel@mulgrave.il.steeleye.com>
On Sat, May 26, 2007 at 07:15:43PM -0500, James Bottomley wrote:
> Actually, it's a thinko on my part ... I thought late_initcall() and
> module_init() are the same level, and hence this would be link order
> dependent. Actually that's only true in the modular case, so the patch
> is fine ... I'll put it in.
I disagree that Grant's patch is fine. Consider:
- CONFIG_SCSI=y
- CONFIG_SCSI_SYM2=y
- CONFIG_SCSI_QLA2XYZ=m
You want the root disc on your sym2 to be found, so you need
SCSI_WAIT_SCAN=y, but you also want to know when qla2xyz has finished
scanning the fabric, so you need SCSI_WAIT_SCAN=m. My patch doesn't
have this problem.
next prev parent reply other threads:[~2007-05-27 0:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-26 19:11 [PATCH] add help to WAIT_SCAN option Grant Grundler
2007-05-26 19:50 ` James Bottomley
2007-05-27 0:06 ` Grant Grundler
2007-05-27 0:15 ` James Bottomley
2007-05-27 0:27 ` Matthew Wilcox [this message]
2007-05-27 0:29 ` James Bottomley
2007-05-27 0:33 ` Matthew Wilcox
2007-05-27 0:53 ` Grant Grundler
2007-05-26 20:44 ` Matthew Wilcox
2007-05-26 22:25 ` Thibaut VARENE
2007-05-26 23:03 ` Matthew Wilcox
2007-05-26 23:10 ` Thibaut VARENE
2007-05-27 0:05 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070527002710.GR5798@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=T-Bone@parisc-linux.org \
--cc=grundler@parisc-linux.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox