[PATCH] dmx3191d: Coding style police

[PATCH] dmx3191d: Coding style police

[Alan Cox]

Signed-off-by: Alan Cox <alan@redhat.com>

diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c linux-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c
--- linux.vanilla-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c	2007-06-07 14:24:28.000000000 +0100
+++ linux-2.6.22-rc4-mm2/drivers/scsi/dmx3191d.c	2007-06-14 13:48:18.000000000 +0100
@@ -113,13 +113,13 @@
 	scsi_scan_host(shost);
 	return 0;
 
- out_free_irq:
+out_free_irq:
 	free_irq(shost->irq, shost);
- out_release_region:
+out_release_region:
 	release_region(io, DMX3191D_REGION_LEN);
- out_disable_device:
+out_disable_device:
 	pci_disable_device(pdev);
- out:
+out:
 	return error;
 }
 

Re: [PATCH] dmx3191d: Coding style police

[Matthew Wilcox]

On Fri, Jun 22, 2007 at 02:24:56PM +0100, Alan Cox wrote:
> - out_free_irq:
> +out_free_irq:

Which CodingStyle mandates that goto labels start in column 0?  It
screws up diff -p to do this.

Re: [PATCH] dmx3191d: Coding style police

[Alan Cox]

On Fri, 22 Jun 2007 07:26:23 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> On Fri, Jun 22, 2007 at 02:24:56PM +0100, Alan Cox wrote:
> > - out_free_irq:
> > +out_free_irq:
> 
> Which CodingStyle mandates that goto labels start in column 0?  It
> screws up diff -p to do this.

The style being the fact almost all of the kernel keeps the label in
column zero ? I'm not greatly fussed by the indent for goto labels, its
the other stuff like missing printk labels that actually matters. However
if your diff -p is buggy how about fixing your diff instead ?

Alan