From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org
Cc: James.Bottomley@steeleye.com, linux-scsi@vger.kernel.org, pj@sgi.com
Subject: Re: [patch 2/7] git scsi misc include fix
Date: Tue, 16 Oct 2007 14:33:53 -0700 [thread overview]
Message-ID: <20071016143353.9a9b6ea6.randy.dunlap@oracle.com> (raw)
In-Reply-To: <200710162128.l9GLSKUF018167@imap1.linux-foundation.org>
On Tue, 16 Oct 2007 14:28:20 -0700 akpm@linux-foundation.org wrote:
> From: Paul Jackson <pj@sgi.com>
>
> The added line in scsi_eh.h:
> struct scatterlist sense_sgl;
> fails to compile, with the error:
> field 'sense_sgl' has incomplete type
> unless scatterlist.h happens to be included
> somehow already ... which it isn't always.
>
> So include scatterlist.h in scsi_eh.h directly.
>
> Signed-off-by: Paul Jackson <pj@sgi.com>
> Cc: James Bottomley <James.Bottomley@steeleye.com>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> include/scsi/scsi_eh.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -puN include/scsi/scsi_eh.h~git-scsi-misc-include-fix include/scsi/scsi_eh.h
> --- a/include/scsi/scsi_eh.h~git-scsi-misc-include-fix
> +++ a/include/scsi/scsi_eh.h
> @@ -4,6 +4,7 @@
> #include <linux/scatterlist.h>
>
> #include <scsi/scsi_cmnd.h>
> +#include <linux/scatterlist.h>
> struct scsi_device;
> struct Scsi_Host;
It's 3 lines above the patch line....
---
~Randy
next prev parent reply other threads:[~2007-10-16 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-16 21:28 [patch 2/7] git scsi misc include fix akpm
2007-10-16 21:33 ` Randy Dunlap [this message]
2007-10-16 22:04 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071016143353.9a9b6ea6.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=James.Bottomley@steeleye.com \
--cc=akpm@linux-foundation.org \
--cc=linux-scsi@vger.kernel.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox