Re: [patch 2/7] git scsi misc include fix

[Paul Jackson <pj@sgi.com>]

Randy wrote:
> >  #include <linux/scatterlist.h>
> >  
> >  #include <scsi/scsi_cmnd.h>
> > +#include <linux/scatterlist.h>
> >  struct scsi_device;
> >  struct Scsi_Host;
> 
> It's 3 lines above the patch line....

Ah - you mean scatterlist.h is now included twice - yup.

First I noticed that scsi_eh.h needed this scatterlist.h include and
sent this patch to akpm.  Then James noticed that my patch just added
scatterlist.h to scsi_eh.h, without removing it from the other .c file
where it was no longer needed, so he sent along a patch that did both -
removing the one include and adding the other.  His patch added the
first scatterlist.h include above, and my earlier patch added the
second.

Now we have both scatterlist.h includes here.

I guess I'll leave it up to James to send along a third patch someday,
that removes one of these includes.

Sharp eyes, Randy - thanks.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@sgi.com> 1.925.600.0401