* Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions [not found] ` <20081210212659.GA6132@zarina> @ 2008-12-10 22:06 ` Vorobiev Dmitri 2008-12-10 22:48 ` Anton Vorontsov 0 siblings, 1 reply; 2+ messages in thread From: Vorobiev Dmitri @ 2008-12-10 22:06 UTC (permalink / raw) To: cbouatmailru Cc: Vorobiev Dmitri, Alan Cox, Julia Lawall, gregkh, linux-kernel, kernel-janitors, linux-scsi > On Wed, Dec 10, 2008 at 08:03:56PM +0200, Vorobiev Dmitri wrote: >> > On Wed, 10 Dec 2008 17:26:26 +0100 (CET) >> > Julia Lawall <julia@diku.dk> wrote: >> > >> >> From: Julia Lawall <julia@diku.dk> >> >> >> >> The return value of the remove function of a driver structure, and >> thus >> >> of >> >> a platform_driver structure, is ultimately ignored >> > >> > Currently >> >> Are there really any plans about actually using the return value? > > It's often used by the drivers, but currently not handled by > the subsystem. For example, _remove() callback might return -EBUSY > or -EAGAIN, which means that whoever called the _remove() should > try later. Sure, it's easy to find drivers, which that return a non-dummy value from the remove() callback thinking that someone up there will take care of the error. The point is, however, that 1) the SGI Indy SCSI controller driver doesn't compile cleanly [2], and SCSI maintainers do not apply the patch because, in principle, the (*remove)() callback should not return int since the return value is discarded [1]; 2) the changes in the platform driver framework are, as it seems, not acceptable because the non-dummy return values can, in principle, be used for error checking. All that I actually care about is to get rid of this: <<< CC [M] drivers/scsi/sgiwd93.o drivers/scsi/sgiwd93.c:314: warning: initialization from incompatible pointer type <<< I don't care whether the compilation warning is gone because [2] is applied, or the entire platform driver framework is combed though to change int to void. Thanks, Dmitri [1] http://kerneltrap.org/mailarchive/linux-scsi/2008/12/3/4300474 [2] http://kerneltrap.org/mailarchive/linux-scsi/2008/11/20/4169644 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions 2008-12-10 22:06 ` [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions Vorobiev Dmitri @ 2008-12-10 22:48 ` Anton Vorontsov 0 siblings, 0 replies; 2+ messages in thread From: Anton Vorontsov @ 2008-12-10 22:48 UTC (permalink / raw) To: Vorobiev Dmitri Cc: Alan Cox, Julia Lawall, gregkh, linux-kernel, kernel-janitors, linux-scsi On Thu, Dec 11, 2008 at 12:06:34AM +0200, Vorobiev Dmitri wrote: > > On Wed, Dec 10, 2008 at 08:03:56PM +0200, Vorobiev Dmitri wrote: > >> > On Wed, 10 Dec 2008 17:26:26 +0100 (CET) > >> > Julia Lawall <julia@diku.dk> wrote: > >> > > >> >> From: Julia Lawall <julia@diku.dk> > >> >> > >> >> The return value of the remove function of a driver structure, and > >> thus > >> >> of > >> >> a platform_driver structure, is ultimately ignored > >> > > >> > Currently > >> > >> Are there really any plans about actually using the return value? > > > > It's often used by the drivers, but currently not handled by > > the subsystem. For example, _remove() callback might return -EBUSY > > or -EAGAIN, which means that whoever called the _remove() should > > try later. > > Sure, it's easy to find drivers, which that return a non-dummy value from > the remove() callback thinking that someone up there will take care of the > error. > > The point is, however, that [...] > SCSI maintainers do not apply the patch This sometimes happens. You can try to repost your original patch, and in the commit message briefly describe that return type is unlikely to change, and give a pointer to this discussion. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2 ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-12-10 22:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <Pine.LNX.4.64.0812101725540.21998@ask.diku.dk>
[not found] ` <20081210163819.17cf4628@lxorguk.ukuu.org.uk>
[not found] ` <45755.88.114.236.15.1228932236.squirrel@webmail.movial.fi>
[not found] ` <20081210212659.GA6132@zarina>
2008-12-10 22:06 ` [PATCH 1/28] drivers/base/platform.c: Drop return value from platform_driver remove functions Vorobiev Dmitri
2008-12-10 22:48 ` Anton Vorontsov
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox