[Bug 12742] New: Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

[Bug 12742] New: Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12742

           Summary: Spinning up disk is observed on standby paths until
                    timeout, resulting in longer path restoration time.
           Product: SCSI Drivers
           Version: 2.5
     KernelVersion: 2.6.27
          Platform: All
        OS/Version: Linux
              Tree: Mainline
            Status: NEW
          Severity: high
          Priority: P1
         Component: Other
        AssignedTo: scsi_drivers-other@kernel-bugs.osdl.org
        ReportedBy: narayanan.rengarajan@hp.com


Latest working kernel version: 2.6.27
Earliest failing kernel version:
Distribution: suse
Hardware Environment:x86_64
Software Environment:sd
Problem Description:

Steps to reproduce:
 1. present a standby lun to the host
 2. do a discovery from the host (scan the scsi bus)
 3. Spinning of disks is  observed in  /var/log/messages

Whenever a device goes offline and comes back, the new sd device takes longer
time to get created. This is because of the spinning up of disk in
sd_spinup_disk fuction as the standby paths would return device not ready with
0x04/0x0b asc/ascq.

recommended patch :
                   diff -pNaur /usr/src/linux/drivers/scsi/sd.c sd.c
--- /usr/src/linux/drivers/scsi/sd.c    2009-02-09 22:24:56.000000000 +0530
+++ sd.c        2009-02-19 16:39:16.000000000 +0530
@@ -1181,8 +1181,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
                 */
                if (sense_valid &&
                    sshdr.sense_key == NOT_READY &&
-                   sshdr.asc == 4 && sshdr.ascq == 3) {
-                       break;          /* manual intervention required */
+                   sshdr.asc == 4 && (sshdr.ascq == 3 || sshdr.ascq == 0x0b ||
sshdr.ascq == 0x0c) ) {
+                       break;  /* manual intervention required || Standby ||
Unavailable */

                /*
                 * Issue command to spin up drive when not ready


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12742] Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

[bugme-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12742





------- Comment #1 from akpm@osdl.org  2009-02-20 02:26 -------
Please submit patches via email, as per
Documentation/SubmittingPatches.

Please send this one to

linux-scsi@vger.kernel.org
akpm@linux-foundation.org


-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 12742] Spinning up disk is observed on standby paths until timeout, resulting in longer path restoration time.

[bugzilla-daemon]

http://bugzilla.kernel.org/show_bug.cgi?id=12742


Narayanan <narayanan.rengarajan@hp.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |CODE_FIX
         Regression|---                         |No




--- Comment #2 from Narayanan <narayanan.rengarajan@hp.com>  2009-04-06 08:52:07 ---
code fix is available in 2.6.29-1

-- 
Configure bugmail: http://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.