public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qla4x: fix ql4_mbx tcp_source_port_num
@ 2010-03-02 22:41 Randy Dunlap
  0 siblings, 0 replies; only message in thread
From: Randy Dunlap @ 2010-03-02 22:41 UTC (permalink / raw)
  To: scsi, james.bottomley
  Cc: David C Somayajulu, Karen Higgins, Ravi Anand, Vikas Chaudhary

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix sparse warning, which indicates a precedence problem and the
data value always being 0:

drivers/scsi/qla4xxx/ql4_mbx.c:470:66: warning: right shift by bigger than source value

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: David C Somayajulu <david.somayajulu@qlogic.com>
Cc: Karen Higgins <karen.higgins@qlogic.com>
Cc: Ravi Anand <ravi.anand@qlogic.com>
Cc: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
---

Sorry if you already received this patch; I thought that I had
already sent it, but I can't find it anywhere.

And how about a MAINTAINERS entry for qla4xxx, please?

 drivers/scsi/qla4xxx/ql4_mbx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2.6.33-git7.orig/drivers/scsi/qla4xxx/ql4_mbx.c
+++ linux-2.6.33-git7/drivers/scsi/qla4xxx/ql4_mbx.c
@@ -467,7 +467,7 @@ int qla4xxx_get_fwddb_entry(struct scsi_
 	if (conn_err_detail)
 		*conn_err_detail = mbox_sts[5];
 	if (tcp_source_port_num)
-		*tcp_source_port_num = (uint16_t) mbox_sts[6] >> 16;
+		*tcp_source_port_num = (uint16_t) (mbox_sts[6] >> 16);
 	if (connection_id)
 		*connection_id = (uint16_t) mbox_sts[6] & 0x00FF;
 	status = QLA_SUCCESS;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-03-02 22:42 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-02 22:41 [PATCH] qla4x: fix ql4_mbx tcp_source_port_num Randy Dunlap

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox