From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Smart <james.smart@emulex.com>
Cc: linux-scsi@vger.kernel.org
Subject: [smatch stuff] re: [SCSI] lpfc 8.3.27: Changed worst case mailbox timeout
Date: Mon, 31 Oct 2011 09:58:13 +0300 [thread overview]
Message-ID: <20111031065813.GA12501@elgon.mountain> (raw)
Smatch complains about a183a15f "[SCSI] lpfc 8.3.27: Changed worst
case mailbox timeout".
drivers/scsi/lpfc/lpfc_sli.c +2220 lpfc_sli_handle_mb_event(66)
error: we previously assumed 'pmb->vport' could be null (see line 2177)
+ pmb->vport ? pmb->vport->vpi : 0,
^^^^^^^^^^
Checked.
+ pmbox->mbxCommand,
+ lpfc_sli_config_mbox_subsys_get(phba,
+ pmb),
+ lpfc_sli_config_mbox_opcode_get(phba,
+ pmb),
+ pmbox->mbxStatus,
+ pmbox->un.varWords[0],
+ pmb->vport->port_state);
^^^^^^^^^^^^
Dereferenced without checking.
regards,
dan carpenter
reply other threads:[~2011-10-31 6:58 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031065813.GA12501@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox