* [smatch stuff] re: [SCSI] lpfc 8.3.27: Changed worst case mailbox timeout
@ 2011-10-31 6:58 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-10-31 6:58 UTC (permalink / raw)
To: James Smart; +Cc: linux-scsi
Smatch complains about a183a15f "[SCSI] lpfc 8.3.27: Changed worst
case mailbox timeout".
drivers/scsi/lpfc/lpfc_sli.c +2220 lpfc_sli_handle_mb_event(66)
error: we previously assumed 'pmb->vport' could be null (see line 2177)
+ pmb->vport ? pmb->vport->vpi : 0,
^^^^^^^^^^
Checked.
+ pmbox->mbxCommand,
+ lpfc_sli_config_mbox_subsys_get(phba,
+ pmb),
+ lpfc_sli_config_mbox_opcode_get(phba,
+ pmb),
+ pmbox->mbxStatus,
+ pmbox->un.varWords[0],
+ pmb->vport->port_state);
^^^^^^^^^^^^
Dereferenced without checking.
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-10-31 6:58 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-31 6:58 [smatch stuff] re: [SCSI] lpfc 8.3.27: Changed worst case mailbox timeout Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox