* [patch 1/2] [SCSI] pmcraid: remove unneeded check
@ 2011-12-16 10:15 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-12-16 10:15 UTC (permalink / raw)
To: Anil Ravindranath
Cc: James E.J. Bottomley, Dan Rosenberg, linux-scsi, kernel-janitors
request_size is zero here so this condition is always false. Also we
already handled negative values some lines earlier so it's not negative
for that reason as well.
It looks like Dan Rosenberg's fix was applied twice by mistake:
b5b515445f4 "[SCSI] pmcraid: reject negative request size"
5f6279da376 "[SCSI] pmcraid: reject negative request size"
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 5163edb..d6bc4e6 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -3870,9 +3870,6 @@ static long pmcraid_ioctl_passthrough(
pmcraid_err("couldn't build passthrough ioadls\n");
goto out_free_buffer;
}
- } else if (request_size < 0) {
- rc = -EINVAL;
- goto out_free_buffer;
}
/* If data is being written into the device, copy the data from user
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-12-16 10:16 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 10:15 [patch 1/2] [SCSI] pmcraid: remove unneeded check Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox