From: Dan Carpenter <dan.carpenter@oracle.com>
To: james.smart@emulex.com
Cc: linux-scsi@vger.kernel.org
Subject: re: [SCSI] lpfc 8.3.28: Add support for ABTS failure handling
Date: Fri, 16 Dec 2011 23:27:45 +0300 [thread overview]
Message-ID: <20111216202745.GE18570@elgon.mountain> (raw)
Hello James Smart,
This is a semi-automatic email about new static checker warnings.
The patch cb69f7decc37: "[SCSI] lpfc 8.3.28: Add support for ABTS
failure handling" from Dec 13, 2011, leads to the following Smatch
complaint:
drivers/scsi/lpfc/lpfc_sli.c +8391 lpfc_sli4_abts_err_handler()
error: we previously assumed 'ndlp' could be null (see line 8387)
drivers/scsi/lpfc/lpfc_sli.c
8386
8387 if (!ndlp || !NLP_CHK_NODE_ACT(ndlp))
^^^^^
New check.
8388 lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
8389 "3115 Node Context not found, driver "
8390 "ignoring abts err event\n");
8391 vport = ndlp->vport;
^^^^^^^^^^^
New dereference. Maybe the intent was to return after the print
statement?
8392 lpfc_printf_log(phba, KERN_WARNING, LOG_SLI,
8393 "3116 Port generated FCP XRI ABORT event on "
regards,
dan carpenter
next reply other threads:[~2011-12-16 20:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-16 20:27 Dan Carpenter [this message]
2011-12-21 15:01 ` [SCSI] lpfc 8.3.28: Add support for ABTS failure handling James Smart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111216202745.GE18570@elgon.mountain \
--to=dan.carpenter@oracle.com \
--cc=james.smart@emulex.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox