* re: [SCSI] lpfc 8.3.28: Add support for ABTS failure handling
@ 2011-12-16 20:27 Dan Carpenter
2011-12-21 15:01 ` James Smart
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2011-12-16 20:27 UTC (permalink / raw)
To: james.smart; +Cc: linux-scsi
Hello James Smart,
This is a semi-automatic email about new static checker warnings.
The patch cb69f7decc37: "[SCSI] lpfc 8.3.28: Add support for ABTS
failure handling" from Dec 13, 2011, leads to the following Smatch
complaint:
drivers/scsi/lpfc/lpfc_sli.c +8391 lpfc_sli4_abts_err_handler()
error: we previously assumed 'ndlp' could be null (see line 8387)
drivers/scsi/lpfc/lpfc_sli.c
8386
8387 if (!ndlp || !NLP_CHK_NODE_ACT(ndlp))
^^^^^
New check.
8388 lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
8389 "3115 Node Context not found, driver "
8390 "ignoring abts err event\n");
8391 vport = ndlp->vport;
^^^^^^^^^^^
New dereference. Maybe the intent was to return after the print
statement?
8392 lpfc_printf_log(phba, KERN_WARNING, LOG_SLI,
8393 "3116 Port generated FCP XRI ABORT event on "
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [SCSI] lpfc 8.3.28: Add support for ABTS failure handling
2011-12-16 20:27 [SCSI] lpfc 8.3.28: Add support for ABTS failure handling Dan Carpenter
@ 2011-12-21 15:01 ` James Smart
0 siblings, 0 replies; 2+ messages in thread
From: James Smart @ 2011-12-21 15:01 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi@vger.kernel.org
Dan,
We should have another patch set coming shortly - will address it in that patch.
-- james s
On 12/16/2011 3:27 PM, Dan Carpenter wrote:
> Hello James Smart,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch cb69f7decc37: "[SCSI] lpfc 8.3.28: Add support for ABTS
> failure handling" from Dec 13, 2011, leads to the following Smatch
> complaint:
>
> drivers/scsi/lpfc/lpfc_sli.c +8391 lpfc_sli4_abts_err_handler()
> error: we previously assumed 'ndlp' could be null (see line 8387)
>
> drivers/scsi/lpfc/lpfc_sli.c
> 8386
> 8387 if (!ndlp || !NLP_CHK_NODE_ACT(ndlp))
> ^^^^^
> New check.
>
> 8388 lpfc_printf_log(phba, KERN_INFO, LOG_SLI,
> 8389 "3115 Node Context not found, driver "
> 8390 "ignoring abts err event\n");
> 8391 vport = ndlp->vport;
> ^^^^^^^^^^^
> New dereference. Maybe the intent was to return after the print
> statement?
>
> 8392 lpfc_printf_log(phba, KERN_WARNING, LOG_SLI,
> 8393 "3116 Port generated FCP XRI ABORT event on "
>
> regards,
> dan carpenter
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 15:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 20:27 [SCSI] lpfc 8.3.28: Add support for ABTS failure handling Dan Carpenter
2011-12-21 15:01 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox