public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] fcoe patch fix for 3.3 (scsi-misc)
@ 2011-12-16 22:24 Robert Love
  2011-12-16 22:24 ` [PATCH] fcoe: remove double check if skb is nonlinear Robert Love
  0 siblings, 1 reply; 2+ messages in thread
From: Robert Love @ 2011-12-16 22:24 UTC (permalink / raw)
  To: linux-scsi

This is just a trivial patch that I wanted to get out before the holidays.

---

Robert Love (1):
      fcoe: remove double check if skb is nonlinear


 drivers/scsi/fcoe/fcoe.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

-- 
Thanks, //Rob

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] fcoe: remove double check if skb is nonlinear
  2011-12-16 22:24 [PATCH] fcoe patch fix for 3.3 (scsi-misc) Robert Love
@ 2011-12-16 22:24 ` Robert Love
  0 siblings, 0 replies; 2+ messages in thread
From: Robert Love @ 2011-12-16 22:24 UTC (permalink / raw)
  To: linux-scsi; +Cc: patrick kelle

skb_linearize already has a check for skb_is_nonlinear,
there is no need to duplicate the check in fcoe.c. This
patch simply removes the unnecessary check and calls
skb_linearize unconditionally.

Reported-by: patrick kelle <patrick.kelle81@gmail.com>
Signed-off-by: Robert Love <robert.w.love@intel.com>
Acked-by: patrick kelle <patrick.kelle81@gmail.com>
---
 drivers/scsi/fcoe/fcoe.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index c18e201..b40d11d 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1670,8 +1670,7 @@ static void fcoe_recv_frame(struct sk_buff *skb)
 			skb->dev ? skb->dev->name : "<NULL>");
 
 	port = lport_priv(lport);
-	if (skb_is_nonlinear(skb))
-		skb_linearize(skb);	/* not ideal */
+	skb_linearize(skb); /* check for skb_is_nonlinear is within skb_linearize */
 
 	/*
 	 * Frame length checks and setting up the header pointers


^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-16 22:24 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-16 22:24 [PATCH] fcoe patch fix for 3.3 (scsi-misc) Robert Love
2011-12-16 22:24 ` [PATCH] fcoe: remove double check if skb is nonlinear Robert Love

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox