public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Marcin Tomczak <marcin.tomczak@intel.com>
Subject: [3.2-rc PATCH 5/8] isci: performance-fix, shorten default "no outbound task" timeout
Date: Fri, 16 Dec 2011 16:53:36 -0800	[thread overview]
Message-ID: <20111217005336.14133.5851.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111217004820.14133.19249.stgit@localhost6.localdomain6>

From: Marcin Tomczak <marcin.tomczak@intel.com>

>From Richard Boyd:
"No task timeout timer reduced from 20 to 2 This timer controls how
long the SCU hardware will hold open the TX side of the connection
before sending a DONE.  The timer allows the hardware to attempt to
optimize the DONE/CLOSE behavior to allow for new COMMAND IU to be
posted.  In practice closing the connection quicker is better."

Signed-off-by: Marcin Tomczak <marcin.tomczak@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/scsi/isci/host.c |    2 +-
 drivers/scsi/isci/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index 3374f1b..ecaa7bb 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host.c
@@ -1697,7 +1697,7 @@ static void sci_controller_set_default_config_parameters(struct isci_host *ihost
 	ihost->user_parameters.ssp_inactivity_timeout = 5;
 	ihost->user_parameters.stp_max_occupancy_timeout = 5;
 	ihost->user_parameters.ssp_max_occupancy_timeout = 20;
-	ihost->user_parameters.no_outbound_task_timeout = 20;
+	ihost->user_parameters.no_outbound_task_timeout = 2;
 }
 
 static void controller_timeout(unsigned long data)
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index 1047108..3c4ddad 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -94,7 +94,7 @@ MODULE_DEVICE_TABLE(pci, isci_id_table);
 
 /* linux isci specific settings */
 
-unsigned char no_outbound_task_to = 20;
+unsigned char no_outbound_task_to = 2;
 module_param(no_outbound_task_to, byte, 0);
 MODULE_PARM_DESC(no_outbound_task_to, "No Outbound Task Timeout (1us incr)");
 


  parent reply	other threads:[~2011-12-17  0:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  0:53 [GIT 3.2-rc PATCH 0/8] isci: platform and hardware enabling updates Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 1/8] isci: cleanup oem parameter and recipe handling Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 2/8] isci: update afe (analog-front-end) recipe for C1 Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 3/8] isci: oem parameter format v1.1 (ssc select) Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 4/8] isci: oem parameter format v1.3 (cable select) Dan Williams
2011-12-17  0:53 ` Dan Williams [this message]
2011-12-17  0:53 ` [3.2-rc PATCH 6/8] isci: link speeds default to gen 2 Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 7/8] isci: remove unused 'isci_tmf->device' field Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 8/8] isci: update version to 1.1 Dan Williams
2011-12-18 13:49 ` [GIT 3.2-rc PATCH 0/8] isci: platform and hardware enabling updates James Bottomley
2011-12-18 18:46   ` Williams, Dan J
2011-12-21 21:05     ` James Bottomley
2011-12-21 22:17       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111217005336.14133.5851.stgit@localhost6.localdomain6 \
    --to=dan.j.williams@intel.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=marcin.tomczak@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox