public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: linux-scsi@vger.kernel.org
Cc: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Subject: [3.2-rc PATCH 6/8] isci: link speeds default to gen 2
Date: Fri, 16 Dec 2011 16:53:41 -0800	[thread overview]
Message-ID: <20111217005341.14133.99327.stgit@localhost6.localdomain6> (raw)
In-Reply-To: <20111217004820.14133.19249.stgit@localhost6.localdomain6>

From: Jeff Skirvin <jeffrey.d.skirvin@intel.com>

Gen-3 operation is marginal, default to gen-2 for now.

Signed-off-by: Jeff Skirvin <jeffrey.d.skirvin@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
 drivers/scsi/isci/host.c |    5 +++--
 drivers/scsi/isci/init.c |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c
index ecaa7bb..b09c36b 100644
--- a/drivers/scsi/isci/host.c
+++ b/drivers/scsi/isci/host.c
@@ -1676,8 +1676,9 @@ static void sci_controller_set_default_config_parameters(struct isci_host *ihost
 
 	/* Initialize all of the phy parameter information. */
 	for (index = 0; index < SCI_MAX_PHYS; index++) {
-		/* Default to 6G (i.e. Gen 3) for now. */
-		ihost->user_parameters.phys[index].max_speed_generation = 3;
+		/* Default to 3G (i.e. Gen 2). */
+		ihost->user_parameters.phys[index].max_speed_generation =
+			SCIC_SDS_PARM_GEN2_SPEED;
 
 		/* the frequencies cannot be 0 */
 		ihost->user_parameters.phys[index].align_insertion_frequency = 0x7f;
diff --git a/drivers/scsi/isci/init.c b/drivers/scsi/isci/init.c
index 3c4ddad..2bcfb40 100644
--- a/drivers/scsi/isci/init.c
+++ b/drivers/scsi/isci/init.c
@@ -114,7 +114,7 @@ u16 stp_inactive_to = 5;
 module_param(stp_inactive_to, ushort, 0);
 MODULE_PARM_DESC(stp_inactive_to, "STP inactivity timeout (100us incr)");
 
-unsigned char phy_gen = 3;
+unsigned char phy_gen = SCIC_SDS_PARM_GEN2_SPEED;
 module_param(phy_gen, byte, 0);
 MODULE_PARM_DESC(phy_gen, "PHY generation (1: 1.5Gbps 2: 3.0Gbps 3: 6.0Gbps)");
 


  parent reply	other threads:[~2011-12-17  0:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-17  0:53 [GIT 3.2-rc PATCH 0/8] isci: platform and hardware enabling updates Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 1/8] isci: cleanup oem parameter and recipe handling Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 2/8] isci: update afe (analog-front-end) recipe for C1 Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 3/8] isci: oem parameter format v1.1 (ssc select) Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 4/8] isci: oem parameter format v1.3 (cable select) Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 5/8] isci: performance-fix, shorten default "no outbound task" timeout Dan Williams
2011-12-17  0:53 ` Dan Williams [this message]
2011-12-17  0:53 ` [3.2-rc PATCH 7/8] isci: remove unused 'isci_tmf->device' field Dan Williams
2011-12-17  0:53 ` [3.2-rc PATCH 8/8] isci: update version to 1.1 Dan Williams
2011-12-18 13:49 ` [GIT 3.2-rc PATCH 0/8] isci: platform and hardware enabling updates James Bottomley
2011-12-18 18:46   ` Williams, Dan J
2011-12-21 21:05     ` James Bottomley
2011-12-21 22:17       ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111217005341.14133.99327.stgit@localhost6.localdomain6 \
    --to=dan.j.williams@intel.com \
    --cc=jeffrey.d.skirvin@intel.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox