* re: [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts.
@ 2012-01-11 9:32 Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-01-11 9:32 UTC (permalink / raw)
To: kgudipat; +Cc: linux-scsi
Hello Krishna Gudipati,
This is a semi-automatic email about new static checker warnings.
The patch 5b7db7af522d: "[SCSI] bfa: Implement LUN Masking feature
using the SCSI Slave Callouts." from Dec 20, 2011, leads to the
following Smatch complaint:
drivers/scsi/bfa/bfad_im.c +962 bfad_im_slave_alloc()
warn: variable dereferenced before check 'rport' (see line 959)
drivers/scsi/bfa/bfad_im.c
957 struct fc_rport *rport = starget_to_rport(scsi_target(sdev));
958 struct bfad_itnim_data_s *itnim_data =
959 (struct bfad_itnim_data_s *) rport->dd_data;
^^^^^^^
New dereference.
960 struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;
961
962 if (!rport || fc_remote_port_chkready(rport))
^^^^^
Old check.
963 return -ENXIO;
964
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts.
[not found] <20120627085800.GA3007@mwanda>
@ 2012-06-27 9:05 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2012-06-27 9:05 UTC (permalink / raw)
To: kgudipat; +Cc: linux-scsi, linux-kernel
Hi,
This bug is still present in linux-next.
regards,
dan carpenter
On Wed, Jan 11, 2012 at 12:32:34PM +0300, Dan Carpenter wrote:
> Hello Krishna Gudipati,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 5b7db7af522d: "[SCSI] bfa: Implement LUN Masking feature
> using the SCSI Slave Callouts." from Dec 20, 2011, leads to the
> following Smatch complaint:
>
> drivers/scsi/bfa/bfad_im.c +962 bfad_im_slave_alloc()
> warn: variable dereferenced before check 'rport' (see line 959)
>
> drivers/scsi/bfa/bfad_im.c
> 957 struct fc_rport *rport = starget_to_rport(scsi_target(sdev));
> 958 struct bfad_itnim_data_s *itnim_data =
> 959 (struct bfad_itnim_data_s *) rport->dd_data;
> ^^^^^^^
> New dereference.
>
> 960 struct bfa_s *bfa = itnim_data->itnim->bfa_itnim->bfa;
> 961
> 962 if (!rport || fc_remote_port_chkready(rport))
> ^^^^^
> Old check.
>
> 963 return -ENXIO;
> 964
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-27 9:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-11 9:32 [SCSI] bfa: Implement LUN Masking feature using the SCSI Slave Callouts Dan Carpenter
[not found] <20120627085800.GA3007@mwanda>
2012-06-27 9:05 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox