* [scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus'
@ 2012-09-14 16:50 Fengguang Wu
2012-09-14 16:59 ` James Bottomley
0 siblings, 1 reply; 2+ messages in thread
From: Fengguang Wu @ 2012-09-14 16:50 UTC (permalink / raw)
To: Shun Fu; +Cc: kernel-janitors, James Bottomley, linux-scsi
Hi Shun,
FYI, kernel build failed on
tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
head: e1daec5547bdb8a53b023852d578409005c69ea7
commit: 8b3fa849abc2b62920d7e4fc4f8e6ce3d0783623 [49/55] [SCSI] mvumi: Add support for Marvell SAS/SATA RAID-on-Chip(ROC) 88RC9580
config: powerpc-allmodconfig
All related error/warning messages:
drivers/scsi/mvumi.c: In function 'mvumi_send_command':
drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors
vim +1880 drivers/scsi/mvumi.c
1875 frame_len = sizeof(*ib_frame) - 4 +
1876 ib_frame->sg_counts * sizeof(struct mvumi_sgl);
1877 if (mhba->hba_capability & HS_CAPABILITY_SUPPORT_DYN_SRC) {
1878 struct mvumi_dyn_list_entry *dle;
1879 dle = ib_entry;
> 1880 dle->src_low_addr = virt_to_bus(ib_frame) & 0xFFFFFFFF;
1881 dle->src_high_addr =
1882 ((virt_to_bus(ib_frame) >> 16) >> 16) & 0xFFFFFFFF;
1883 dle->if_length = (frame_len >> 2) & 0xFFF;
1884 } else {
1885 memcpy(ib_entry, ib_frame, frame_len);
---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu, Yuanhan Liu Intel Corporation
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus'
2012-09-14 16:50 [scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus' Fengguang Wu
@ 2012-09-14 16:59 ` James Bottomley
0 siblings, 0 replies; 2+ messages in thread
From: James Bottomley @ 2012-09-14 16:59 UTC (permalink / raw)
To: Fengguang Wu
Cc: Shun Fu, kernel-janitors@vger.kernel.org,
linux-scsi@vger.kernel.org
On Sat, 2012-09-15 at 00:50 +0800, Fengguang Wu wrote:
> Hi Shun,
>
> FYI, kernel build failed on
>
> tree: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git misc
> head: e1daec5547bdb8a53b023852d578409005c69ea7
> commit: 8b3fa849abc2b62920d7e4fc4f8e6ce3d0783623 [49/55] [SCSI] mvumi: Add support for Marvell SAS/SATA RAID-on-Chip(ROC) 88RC9580
> config: powerpc-allmodconfig
>
> All related error/warning messages:
>
> drivers/scsi/mvumi.c: In function 'mvumi_send_command':
> drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus' [-Werror=implicit-function-declaration]
> cc1: some warnings being treated as errors
>
> vim +1880 drivers/scsi/mvumi.c
> 1875 frame_len = sizeof(*ib_frame) - 4 +
> 1876 ib_frame->sg_counts * sizeof(struct mvumi_sgl);
> 1877 if (mhba->hba_capability & HS_CAPABILITY_SUPPORT_DYN_SRC) {
> 1878 struct mvumi_dyn_list_entry *dle;
> 1879 dle = ib_entry;
> > 1880 dle->src_low_addr = virt_to_bus(ib_frame) & 0xFFFFFFFF;
> 1881 dle->src_high_addr =
> 1882 ((virt_to_bus(ib_frame) >> 16) >> 16) & 0xFFFFFFFF;
> 1883 dle->if_length = (frame_len >> 2) & 0xFFF;
> 1884 } else {
> 1885 memcpy(ib_entry, ib_frame, frame_len);
OK, that's not fixable without a rewrite.
Marvell people, please rewrite. I've dropped the patch from the SCSI
tree.
James
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-09-14 16:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-09-14 16:50 [scsi:misc 49/55] drivers/scsi/mvumi.c:1880:3: error: implicit declaration of function 'virt_to_bus' Fengguang Wu
2012-09-14 16:59 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox