* [patch] target: update error handling for sbc_setup_write_same()
@ 2012-11-27 14:27 Dan Carpenter
2012-11-28 3:03 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2012-11-27 14:27 UTC (permalink / raw)
To: Nicholas A. Bellinger; +Cc: linux-scsi, target-devel, kernel-janitors
We recently changed this to return positive subsystem error codes so the
error handling needs to be updated.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
index 943c689..4fd22cd 100644
--- a/drivers/target/target_core_sbc.c
+++ b/drivers/target/target_core_sbc.c
@@ -439,7 +439,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
cmd->t_task_lba = get_unaligned_be64(&cdb[12]);
ret = sbc_setup_write_same(cmd, &cdb[10], ops);
- if (ret < 0)
+ if (ret)
return ret;
break;
default:
@@ -512,7 +512,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
cmd->t_task_lba = get_unaligned_be64(&cdb[2]);
ret = sbc_setup_write_same(cmd, &cdb[1], ops);
- if (ret < 0)
+ if (ret)
return ret;
break;
case WRITE_SAME:
@@ -530,7 +530,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
* of byte 1 bit 3 UNMAP instead of original reserved field
*/
ret = sbc_setup_write_same(cmd, &cdb[1], ops);
- if (ret < 0)
+ if (ret)
return ret;
break;
case VERIFY:
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] target: update error handling for sbc_setup_write_same()
2012-11-27 14:27 [patch] target: update error handling for sbc_setup_write_same() Dan Carpenter
@ 2012-11-28 3:03 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2012-11-28 3:03 UTC (permalink / raw)
To: Dan Carpenter; +Cc: linux-scsi, target-devel, kernel-janitors
Hi Dan,
On Tue, 2012-11-27 at 17:27 +0300, Dan Carpenter wrote:
> We recently changed this to return positive subsystem error codes so the
> error handling needs to be updated.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
A nice catch on this sense_reason_t return breakage that I managed to
introduce within for-3.8 code.
Applied to for-next.
Thank you!
--nab
> diff --git a/drivers/target/target_core_sbc.c b/drivers/target/target_core_sbc.c
> index 943c689..4fd22cd 100644
> --- a/drivers/target/target_core_sbc.c
> +++ b/drivers/target/target_core_sbc.c
> @@ -439,7 +439,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
> cmd->t_task_lba = get_unaligned_be64(&cdb[12]);
>
> ret = sbc_setup_write_same(cmd, &cdb[10], ops);
> - if (ret < 0)
> + if (ret)
> return ret;
> break;
> default:
> @@ -512,7 +512,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
> cmd->t_task_lba = get_unaligned_be64(&cdb[2]);
>
> ret = sbc_setup_write_same(cmd, &cdb[1], ops);
> - if (ret < 0)
> + if (ret)
> return ret;
> break;
> case WRITE_SAME:
> @@ -530,7 +530,7 @@ sbc_parse_cdb(struct se_cmd *cmd, struct sbc_ops *ops)
> * of byte 1 bit 3 UNMAP instead of original reserved field
> */
> ret = sbc_setup_write_same(cmd, &cdb[1], ops);
> - if (ret < 0)
> + if (ret)
> return ret;
> break;
> case VERIFY:
> --
> To unsubscribe from this list: send the line "unsubscribe target-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-28 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-27 14:27 [patch] target: update error handling for sbc_setup_write_same() Dan Carpenter
2012-11-28 3:03 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).