* [patch] [SCSI] mpt fusion: declare some sizes as unsigned
@ 2013-11-01 10:24 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2013-11-01 10:24 UTC (permalink / raw)
To: Nagalakshmi Nandigama
Cc: Sreekanth Reddy, support, DL-MPTFusionLinux, linux-scsi,
kernel-janitors
In mptctl_do_mpt_command() we cap the upper bound of .maxSenseBytes but
we don't check for negative values:
if (karg.maxSenseBytes > MPT_SENSE_BUFFER_SIZE)
I've fixed this by making the type unsigned and I changed the
surrounding types to match as well.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/message/fusion/mptctl.h b/drivers/message/fusion/mptctl.h
index d564cc9..9ea5a18 100644
--- a/drivers/message/fusion/mptctl.h
+++ b/drivers/message/fusion/mptctl.h
@@ -324,11 +324,11 @@ struct mpt_ioctl_command {
char __user *dataInBufPtr;
char __user *dataOutBufPtr;
char __user *senseDataPtr;
- int maxReplyBytes;
- int dataInSize;
- int dataOutSize;
- int maxSenseBytes;
- int dataSgeOffset;
+ u32 maxReplyBytes;
+ u32 dataInSize;
+ u32 dataOutSize;
+ u32 maxSenseBytes;
+ u32 dataSgeOffset;
char MF[1];
};
@@ -343,11 +343,11 @@ struct mpt_ioctl_command32 {
u32 dataInBufPtr;
u32 dataOutBufPtr;
u32 senseDataPtr;
- int maxReplyBytes;
- int dataInSize;
- int dataOutSize;
- int maxSenseBytes;
- int dataSgeOffset;
+ u32 maxReplyBytes;
+ u32 dataInSize;
+ u32 dataOutSize;
+ u32 maxSenseBytes;
+ u32 dataSgeOffset;
char MF[1];
};
#endif /*}*/
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2013-11-01 10:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-11-01 10:24 [patch] [SCSI] mpt fusion: declare some sizes as unsigned Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox