From: Christoph Hellwig <hch@lst.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: James Bottomley <jbottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning
Date: Mon, 5 Jan 2015 14:02:59 +0100 [thread overview]
Message-ID: <20150105130259.GA25960@lst.de> (raw)
In-Reply-To: <54AA6F75.7040607@acm.org>
I don't like this. The problem is that sd_shutdown shouldn't even try
to grab a reference to the scsi device, nevermind the HBA module.
So I'd say this need a two step fix:
(1) stop trying to call try_module_get from sd_shutdown
(2) properly propagate the try_module_get return value
next prev parent reply other threads:[~2015-01-05 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-05 11:03 [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning Bart Van Assche
2015-01-05 13:02 ` Christoph Hellwig [this message]
2015-01-18 15:29 ` Christoph Hellwig
2015-01-18 16:22 ` James Bottomley
2015-01-18 16:47 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150105130259.GA25960@lst.de \
--to=hch@lst.de \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=jbottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox