Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Bart Van Assche <bvanassche@acm.org>,
	James Bottomley <jbottomley@parallels.com>,
	Hannes Reinecke <hare@suse.de>, Don Brace <brace77070@gmail.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning
Date: Sun, 18 Jan 2015 07:29:40 -0800	[thread overview]
Message-ID: <20150118152940.GB10781@infradead.org> (raw)
In-Reply-To: <20150105130259.GA25960@lst.de>

On Mon, Jan 05, 2015 at 02:02:59PM +0100, Christoph Hellwig wrote:
> I don't like this.  The problem is that sd_shutdown shouldn't even try
> to grab a reference to the scsi device, nevermind the HBA module.

We're fairly late in th 3.19 cycle, and it seems like the proper
fix for the root cause might take a while.  Thus I'm tempte to
add this as the simplest band aid and sort out the root cause
for 3.20.

Does anyone else have a better idea?

  reply	other threads:[~2015-01-18 15:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-05 11:03 [PATCH for kernel 3.19] Avoid that scsi_device_put() triggers a kernel warning Bart Van Assche
2015-01-05 13:02 ` Christoph Hellwig
2015-01-18 15:29   ` Christoph Hellwig [this message]
2015-01-18 16:22 ` James Bottomley
2015-01-18 16:47   ` James Bottomley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150118152940.GB10781@infradead.org \
    --to=hch@infradead.org \
    --cc=brace77070@gmail.com \
    --cc=bvanassche@acm.org \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=jbottomley@parallels.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox