public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 4/8] megaraid_sas : Disable interrupt_mask before enabling hardware interrupts
@ 2015-01-05 14:36 Sumit.Saxena
  2015-01-07  0:31 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: Sumit.Saxena @ 2015-01-05 14:36 UTC (permalink / raw)
  To: linux-scsi; +Cc: stable, martin.petersen, hch, jbottomley, kashyap.desai

Update driver "mask_interrupts" before enable/disable hardware interrupt in order to avoid missing interrupts because of "mask_interrupts" still set to 1 and hardware interrupts are
enabled.

Cc: <stable@vger.kernel.org>

Signed-off-by: Sumit Saxena <sumit.saxena@avagotech.com>
Signed-off-by: Chaitra Basappa <chaitra.basappa@avagotech.com>
---
 drivers/scsi/megaraid/megaraid_sas_fusion.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index fe60743..a703c86 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.c
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c
@@ -102,6 +102,8 @@ megasas_enable_intr_fusion(struct megasas_instance *instance)
 {
 	struct megasas_register_set __iomem *regs;
 	regs = instance->reg_set;
+
+	instance->mask_interrupts = 0;
 	/* For Thunderbolt/Invader also clear intr on enable */
 	writel(~0, &regs->outbound_intr_status);
 	readl(&regs->outbound_intr_status);
@@ -110,7 +112,6 @@ megasas_enable_intr_fusion(struct megasas_instance *instance)
 
 	/* Dummy readl to force pci flush */
 	readl(&regs->outbound_intr_mask);
-	instance->mask_interrupts = 0;
 }
 
 /**
-- 
1.7.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 4/8] megaraid_sas : Disable interrupt_mask before enabling hardware interrupts
  2015-01-05 14:36 [PATCH 4/8] megaraid_sas : Disable interrupt_mask before enabling hardware interrupts Sumit.Saxena
@ 2015-01-07  0:31 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2015-01-07  0:31 UTC (permalink / raw)
  To: Sumit.Saxena
  Cc: linux-scsi, stable, martin.petersen, hch, jbottomley,
	kashyap.desai

>>>>> "Sumit" ==   <Sumit.Saxena@avagotech.com> writes:

Sumit> Update driver "mask_interrupts" before enable/disable hardware
Sumit> interrupt in order to avoid missing interrupts because of
Sumit> "mask_interrupts" still set to 1 and hardware interrupts are
Sumit> enabled.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-07  0:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-05 14:36 [PATCH 4/8] megaraid_sas : Disable interrupt_mask before enabling hardware interrupts Sumit.Saxena
2015-01-07  0:31 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox