From: Christoph Hellwig <hch@infradead.org>
To: Sumit.Saxena@avagotech.com
Cc: linux-scsi@vger.kernel.org, thenzl@redhat.com,
martin.petersen@oracle.com, hch@infradead.org,
jbottomley@parallels.com, kashyap.desai@avagotech.com
Subject: Re: [PATCH v3 6/18] megaraid_sas : Use Block layer tag support for internal command indexing
Date: Mon, 11 May 2015 02:18:05 -0700 [thread overview]
Message-ID: <20150511091805.GG28820@infradead.org> (raw)
In-Reply-To: <201504231103.t3NB3e1u029800@palmhbs0.lsi.com>
> @@ -1668,6 +1655,10 @@ static int megasas_slave_configure(struct scsi_device *sdev)
> blk_queue_rq_timeout(sdev->request_queue,
> MEGASAS_DEFAULT_CMD_TIMEOUT * HZ);
>
> + sdev_printk(KERN_INFO, sdev, "qdepth(%d), tagged(%d), "
> + "scsi_level(%d), cmd_que(%d)\n", sdev->queue_depth,
> + sdev->tagged_supported, sdev->scsi_level,
> + (sdev->inquiry[7] & 2) >> 1);
This noisy printk a) doesn't belong into this patch, and b) shouldn't be
a added at all.
next prev parent reply other threads:[~2015-05-11 9:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 11:01 [PATCH v3 6/18] megaraid_sas : Use Block layer tag support for internal command indexing Sumit.Saxena
2015-05-11 9:18 ` Christoph Hellwig [this message]
2015-05-11 9:57 ` Sumit Saxena
2015-05-12 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150511091805.GG28820@infradead.org \
--to=hch@infradead.org \
--cc=Sumit.Saxena@avagotech.com \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox