From: Sumit Saxena <sumit.saxena@avagotech.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-scsi@vger.kernel.org, thenzl@redhat.com,
martin.petersen@oracle.com, jbottomley@parallels.com,
Kashyap Desai <kashyap.desai@avagotech.com>
Subject: RE: [PATCH v3 6/18] megaraid_sas : Use Block layer tag support for internal command indexing
Date: Mon, 11 May 2015 15:27:19 +0530 [thread overview]
Message-ID: <5e1ce6ee219828a9d0d000be4836f973@mail.gmail.com> (raw)
In-Reply-To: <20150511091805.GG28820@infradead.org>
>-----Original Message-----
>From: Christoph Hellwig [mailto:hch@infradead.org]
>Sent: Monday, May 11, 2015 2:48 PM
>To: Sumit.Saxena@avagotech.com
>Cc: linux-scsi@vger.kernel.org; thenzl@redhat.com;
>martin.petersen@oracle.com; hch@infradead.org;
>jbottomley@parallels.com; kashyap.desai@avagotech.com
>Subject: Re: [PATCH v3 6/18] megaraid_sas : Use Block layer tag support
for
>internal command indexing
>
>> @@ -1668,6 +1655,10 @@ static int megasas_slave_configure(struct
>scsi_device *sdev)
>> blk_queue_rq_timeout(sdev->request_queue,
>> MEGASAS_DEFAULT_CMD_TIMEOUT * HZ);
>>
>> + sdev_printk(KERN_INFO, sdev, "qdepth(%d), tagged(%d), "
>> + "scsi_level(%d), cmd_que(%d)\n", sdev->queue_depth,
>> + sdev->tagged_supported, sdev->scsi_level,
>> + (sdev->inquiry[7] & 2) >> 1);
>
>This noisy printk a) doesn't belong into this patch, and b) shouldn't be
a added
>at all.
Yes, it's not needed. I will remove this printk. If I resend only this
patch, then subsequent patches will be affected and needs to be recreated.
If you are Ok, then I can send a patch to remove this printk rebased on
top of this series.
Please let me know your response.
next prev parent reply other threads:[~2015-05-11 9:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 11:01 [PATCH v3 6/18] megaraid_sas : Use Block layer tag support for internal command indexing Sumit.Saxena
2015-05-11 9:18 ` Christoph Hellwig
2015-05-11 9:57 ` Sumit Saxena [this message]
2015-05-12 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e1ce6ee219828a9d0d000be4836f973@mail.gmail.com \
--to=sumit.saxena@avagotech.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox