From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] sg: remove unreachable code in SET_FORCE_LOW_DMA
Date: Wed, 1 Feb 2017 14:00:48 +0100 [thread overview]
Message-ID: <20170201130048.GA5125@lst.de> (raw)
In-Reply-To: <1485948399-83339-1-git-send-email-hare@suse.de>
On Wed, Feb 01, 2017 at 12:26:39PM +0100, Hannes Reinecke wrote:
> The low_dma value is always '1' in that branch, so the remaining
> 'if' statement can never be reached.
>
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/scsi/sg.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index dbe5b4b..652b934 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -890,14 +890,9 @@ static int max_sectors_bytes(struct request_queue *q)
> result = get_user(val, ip);
> if (result)
> return result;
> - if (val) {
> + if (val)
> sfp->low_dma = 1;
> - if ((0 == sfp->low_dma) && (0 == sg_res_in_use(sfp))) {
> - val = (int) sfp->reserve.bufflen;
> - sg_remove_scat(sfp, &sfp->reserve);
> - sg_build_reserve(sfp, val);
> - }
> - } else {
> + else {
I think the proper fix is to check sfp->low_dma for 0 before updating
it, at least that seems to be the intent here.
next prev parent reply other threads:[~2017-02-01 13:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 11:26 [PATCH] sg: remove unreachable code in SET_FORCE_LOW_DMA Hannes Reinecke
2017-02-01 13:00 ` Christoph Hellwig [this message]
2017-02-01 13:03 ` Christoph Hellwig
2017-02-01 13:06 ` Hannes Reinecke
2017-02-01 13:05 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201130048.GA5125@lst.de \
--to=hch@lst.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox