From: Christoph Hellwig <hch@lst.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] sg: remove unreachable code in SET_FORCE_LOW_DMA
Date: Wed, 1 Feb 2017 14:03:42 +0100 [thread overview]
Message-ID: <20170201130341.GA5351@lst.de> (raw)
In-Reply-To: <20170201130048.GA5125@lst.de>
On Wed, Feb 01, 2017 at 02:00:48PM +0100, Christoph Hellwig wrote:
> I think the proper fix is to check sfp->low_dma for 0 before updating
> it, at least that seems to be the intent here.
Looking at this code a bit more I think the actual, real proper fix
is to remove the SET_FORCE_LOW_DMA entirely (except maybe the flag
for SG_GET_LOW_DMA and procfs output). The block layer already does
bounce buffering if the DMA addressing constraints are not met,
so all this should just go away.
Btw, any rason Doug isn't on Cc on these sg.c patches?
next prev parent reply other threads:[~2017-02-01 13:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-01 11:26 [PATCH] sg: remove unreachable code in SET_FORCE_LOW_DMA Hannes Reinecke
2017-02-01 13:00 ` Christoph Hellwig
2017-02-01 13:03 ` Christoph Hellwig [this message]
2017-02-01 13:06 ` Hannes Reinecke
2017-02-01 13:05 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170201130341.GA5351@lst.de \
--to=hch@lst.de \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox