* [PATCH] scsi: remove 'list' entry from struct scsi_cmnd
@ 2020-05-07 6:26 Hannes Reinecke
2020-05-07 6:28 ` Christoph Hellwig
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Hannes Reinecke @ 2020-05-07 6:26 UTC (permalink / raw)
To: Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi, Hannes Reinecke
Leftover from commandlist removal.
Fixes: c5a9707672fe ("scsi: core: Remove cmd_list functionality")
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/aacraid/aachba.c | 1 -
include/scsi/scsi_cmnd.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aachba.c
index eb72ac8136c3..2b868f8db8ff 100644
--- a/drivers/scsi/aacraid/aachba.c
+++ b/drivers/scsi/aacraid/aachba.c
@@ -814,7 +814,6 @@ int aac_probe_container(struct aac_dev *dev, int cid)
kfree(scsidev);
return -ENOMEM;
}
- scsicmd->list.next = NULL;
scsicmd->scsi_done = aac_probe_container_scsi_done;
scsicmd->device = scsidev;
diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h
index 80ac89e47b47..7f047fdd34ac 100644
--- a/include/scsi/scsi_cmnd.h
+++ b/include/scsi/scsi_cmnd.h
@@ -68,7 +68,6 @@ struct scsi_pointer {
struct scsi_cmnd {
struct scsi_request req;
struct scsi_device *device;
- struct list_head list; /* scsi_cmnd participates in queue lists */
struct list_head eh_entry; /* entry for the host eh_cmd_q */
struct delayed_work abort_work;
--
2.16.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: remove 'list' entry from struct scsi_cmnd
2020-05-07 6:26 [PATCH] scsi: remove 'list' entry from struct scsi_cmnd Hannes Reinecke
@ 2020-05-07 6:28 ` Christoph Hellwig
2020-05-07 15:26 ` Bart Van Assche
2020-05-08 1:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2020-05-07 6:28 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K. Petersen, Christoph Hellwig, James Bottomley,
linux-scsi
On Thu, May 07, 2020 at 08:26:42AM +0200, Hannes Reinecke wrote:
> Leftover from commandlist removal.
>
> Fixes: c5a9707672fe ("scsi: core: Remove cmd_list functionality")
> Signed-off-by: Hannes Reinecke <hare@suse.de>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: remove 'list' entry from struct scsi_cmnd
2020-05-07 6:26 [PATCH] scsi: remove 'list' entry from struct scsi_cmnd Hannes Reinecke
2020-05-07 6:28 ` Christoph Hellwig
@ 2020-05-07 15:26 ` Bart Van Assche
2020-05-08 1:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Bart Van Assche @ 2020-05-07 15:26 UTC (permalink / raw)
To: Hannes Reinecke, Martin K. Petersen
Cc: Christoph Hellwig, James Bottomley, linux-scsi
On 2020-05-06 23:26, Hannes Reinecke wrote:
> Leftover from commandlist removal.
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: remove 'list' entry from struct scsi_cmnd
2020-05-07 6:26 [PATCH] scsi: remove 'list' entry from struct scsi_cmnd Hannes Reinecke
2020-05-07 6:28 ` Christoph Hellwig
2020-05-07 15:26 ` Bart Van Assche
@ 2020-05-08 1:13 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2020-05-08 1:13 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Martin K . Petersen, linux-scsi, James Bottomley,
Christoph Hellwig
On Thu, 7 May 2020 08:26:42 +0200, Hannes Reinecke wrote:
> Leftover from commandlist removal.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: core: Remove 'list' entry from struct scsi_cmnd
https://git.kernel.org/mkp/scsi/c/646d4b507626
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-08 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 6:26 [PATCH] scsi: remove 'list' entry from struct scsi_cmnd Hannes Reinecke
2020-05-07 6:28 ` Christoph Hellwig
2020-05-07 15:26 ` Bart Van Assche
2020-05-08 1:13 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox