* [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk
@ 2020-05-07 13:17 Hans de Goede
2020-05-07 13:49 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Hans de Goede @ 2020-05-07 13:17 UTC (permalink / raw)
To: Oliver Neukum, Alan Stern
Cc: Hans de Goede, Greg Kroah-Hartman, linux-usb, linux-scsi,
Julian Groß
The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
request, causing probing it to take several minutes (and several resets).
Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
Reported-by: Julian Groß <julian.g@posteo.de>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
drivers/usb/storage/unusual_uas.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
index 1b23741036ee..37157ed9a881 100644
--- a/drivers/usb/storage/unusual_uas.h
+++ b/drivers/usb/storage/unusual_uas.h
@@ -28,6 +28,13 @@
* and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
*/
+/* Reported-by: Julian Groß <julian.g@posteo.de> */
+UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
+ "LaCie",
+ "2Big Quadra USB3",
+ USB_SC_DEVICE, USB_PR_DEVICE, NULL,
+ US_FL_NO_REPORT_OPCODES),
+
/*
* Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
* commands in UAS mode. Observed with the 1.28 firmware; are there others?
--
2.26.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk
2020-05-07 13:17 [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk Hans de Goede
@ 2020-05-07 13:49 ` Greg Kroah-Hartman
2020-05-07 13:56 ` Hans de Goede
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2020-05-07 13:49 UTC (permalink / raw)
To: Hans de Goede
Cc: Oliver Neukum, Alan Stern, linux-usb, linux-scsi,
Julian Groß
On Thu, May 07, 2020 at 03:17:08PM +0200, Hans de Goede wrote:
> The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
> request, causing probing it to take several minutes (and several resets).
>
> Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
>
> Reported-by: Julian Groß <julian.g@posteo.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 1b23741036ee..37157ed9a881 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -28,6 +28,13 @@
> * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
> */
>
> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> + "LaCie",
> + "2Big Quadra USB3",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_NO_REPORT_OPCODES),
> +
> /*
> * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
> * commands in UAS mode. Observed with the 1.28 firmware; are there others?
> --
> 2.26.0
>
Already in my tree and in linux-next and will go to Linus this week,
sorry.
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk
2020-05-07 13:49 ` Greg Kroah-Hartman
@ 2020-05-07 13:56 ` Hans de Goede
0 siblings, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2020-05-07 13:56 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Oliver Neukum, Alan Stern, linux-usb, linux-scsi,
Julian Groß
Hi,
On 5/7/20 3:49 PM, Greg Kroah-Hartman wrote:
> On Thu, May 07, 2020 at 03:17:08PM +0200, Hans de Goede wrote:
>> The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
>> request, causing probing it to take several minutes (and several resets).
>>
>> Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
>>
>> Reported-by: Julian Groß <julian.g@posteo.de>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>> drivers/usb/storage/unusual_uas.h | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
>> index 1b23741036ee..37157ed9a881 100644
>> --- a/drivers/usb/storage/unusual_uas.h
>> +++ b/drivers/usb/storage/unusual_uas.h
>> @@ -28,6 +28,13 @@
>> * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
>> */
>>
>> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
>> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
>> + "LaCie",
>> + "2Big Quadra USB3",
>> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>> + US_FL_NO_REPORT_OPCODES),
>> +
>> /*
>> * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
>> * commands in UAS mode. Observed with the 1.28 firmware; are there others?
>> --
>> 2.26.0
>>
>
> Already in my tree and in linux-next and will go to Linus this week,
> sorry.
No problem, I'm happy to see small but important fixes like this getting
picked up :)
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-05-07 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-07 13:17 [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk Hans de Goede
2020-05-07 13:49 ` Greg Kroah-Hartman
2020-05-07 13:56 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox