* [PATCH v2] qla2xxx: Return EBUSY on fcport deletion
@ 2020-10-12 16:41 Daniel Wagner
2020-10-12 16:54 ` Arun Easi
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Wagner @ 2020-10-12 16:41 UTC (permalink / raw)
To: Nilesh Javali, Arun Easi; +Cc: linux-scsi, linux-kernel, Daniel Wagner
When the fcport is about to be deleted we should return EBUSY instead
of ENODEV. Only for EBUSY the request will be requeued in a multipath
setup.
Also in case we have a valid qpair but the firmware has not yet
started return EBUSY to avoid dropping the request.
Signed-off-by: Daniel Wagner <dwagner@suse.de>
---
v2: rebased on mkp/staging
drivers/scsi/qla2xxx/qla_nvme.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
index 2cd9bd288910..fded1e3bc9e0 100644
--- a/drivers/scsi/qla2xxx/qla_nvme.c
+++ b/drivers/scsi/qla2xxx/qla_nvme.c
@@ -555,8 +555,11 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
fcport = qla_rport->fcport;
- if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
+ if ((qpair && !qpair->fw_started) ||
(fcport && fcport->deleted))
+ return -EBUSY;
+
+ if (!qpair || !fcport)
return -ENODEV;
vha = fcport->vha;
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] qla2xxx: Return EBUSY on fcport deletion
2020-10-12 16:41 [PATCH v2] qla2xxx: Return EBUSY on fcport deletion Daniel Wagner
@ 2020-10-12 16:54 ` Arun Easi
0 siblings, 0 replies; 2+ messages in thread
From: Arun Easi @ 2020-10-12 16:54 UTC (permalink / raw)
To: Daniel Wagner; +Cc: Nilesh Javali, linux-scsi, linux-kernel
On Mon, 12 Oct 2020, 9:41am, Daniel Wagner wrote:
> When the fcport is about to be deleted we should return EBUSY instead
> of ENODEV. Only for EBUSY the request will be requeued in a multipath
> setup.
>
> Also in case we have a valid qpair but the firmware has not yet
> started return EBUSY to avoid dropping the request.
>
> Signed-off-by: Daniel Wagner <dwagner@suse.de>
> ---
>
> v2: rebased on mkp/staging
>
> drivers/scsi/qla2xxx/qla_nvme.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 2cd9bd288910..fded1e3bc9e0 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -555,8 +555,11 @@ static int qla_nvme_post_cmd(struct nvme_fc_local_port *lport,
>
> fcport = qla_rport->fcport;
>
> - if (!qpair || !fcport || (qpair && !qpair->fw_started) ||
> + if ((qpair && !qpair->fw_started) ||
> (fcport && fcport->deleted))
> + return -EBUSY;
> +
> + if (!qpair || !fcport)
> return -ENODEV;
>
> vha = fcport->vha;
>
Please move up the "(!qpair || !fcport)" check; you can avoid the
qpair/fcport check in the first "if" condition, then.
Regards,
-Arun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-12 16:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-12 16:41 [PATCH v2] qla2xxx: Return EBUSY on fcport deletion Daniel Wagner
2020-10-12 16:54 ` Arun Easi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox