* [PATCH v2 1/9] dt-bindings: ufs: qcom: Add sm6115 binding
[not found] <20220903174150.3566935-1-iskren.chernev@gmail.com>
@ 2022-09-03 17:41 ` Iskren Chernev
2022-09-06 8:29 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Iskren Chernev @ 2022-09-03 17:41 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring
Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
Iskren Chernev, Andy Gross, Konrad Dybcio, Alim Akhtar,
Avri Altman, Bart Van Assche, Krzysztof Kozlowski, linux-scsi,
linux-kernel
Add SM6115 UFS to DT schema.
Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
---
.../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++
1 file changed, 26 insertions(+)
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
index f2d6298d926c..be55a5dfc68f 100644
--- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
+++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
@@ -28,6 +28,7 @@ properties:
- qcom,msm8998-ufshc
- qcom,sc8280xp-ufshc
- qcom,sdm845-ufshc
+ - qcom,sm6115-ufshc
- qcom,sm6350-ufshc
- qcom,sm8150-ufshc
- qcom,sm8250-ufshc
@@ -178,6 +179,31 @@ allOf:
minItems: 1
maxItems: 1
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - qcom,sm6115-ufshc
+ then:
+ properties:
+ clocks:
+ minItems: 8
+ maxItems: 8
+ clock-names:
+ items:
+ - const: core_clk
+ - const: bus_aggr_clk
+ - const: iface_clk
+ - const: core_clk_unipro
+ - const: core_clk_ice
+ - const: ref_clk
+ - const: tx_lane0_sync_clk
+ - const: rx_lane0_sync_clk
+ reg:
+ minItems: 2
+ maxItems: 2
+
# TODO: define clock bindings for qcom,msm8994-ufshc
unevaluatedProperties: false
--
2.37.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/9] dt-bindings: ufs: qcom: Add sm6115 binding
2022-09-03 17:41 ` [PATCH v2 1/9] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
@ 2022-09-06 8:29 ` Krzysztof Kozlowski
2022-09-06 8:38 ` Iskren Chernev
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-09-06 8:29 UTC (permalink / raw)
To: Iskren Chernev, Bjorn Andersson, Rob Herring
Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
Andy Gross, Konrad Dybcio, Alim Akhtar, Avri Altman,
Bart Van Assche, Krzysztof Kozlowski, linux-scsi, linux-kernel
On 03/09/2022 19:41, Iskren Chernev wrote:
> Add SM6115 UFS to DT schema.
>
> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
> ---
> .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> index f2d6298d926c..be55a5dfc68f 100644
> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
> @@ -28,6 +28,7 @@ properties:
> - qcom,msm8998-ufshc
> - qcom,sc8280xp-ufshc
> - qcom,sdm845-ufshc
> + - qcom,sm6115-ufshc
> - qcom,sm6350-ufshc
> - qcom,sm8150-ufshc
> - qcom,sm8250-ufshc
> @@ -178,6 +179,31 @@ allOf:
> minItems: 1
> maxItems: 1
>
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> + - qcom,sm6115-ufshc
> + then:
> + properties:
> + clocks:
> + minItems: 8
> + maxItems: 8
> + clock-names:
> + items:
> + - const: core_clk
> + - const: bus_aggr_clk
> + - const: iface_clk
> + - const: core_clk_unipro
> + - const: core_clk_ice
This still is not naming and order of sdm845.
> + - const: ref_clk
> + - const: tx_lane0_sync_clk
> + - const: rx_lane0_sync_clk
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 1/9] dt-bindings: ufs: qcom: Add sm6115 binding
2022-09-06 8:29 ` Krzysztof Kozlowski
@ 2022-09-06 8:38 ` Iskren Chernev
0 siblings, 0 replies; 3+ messages in thread
From: Iskren Chernev @ 2022-09-06 8:38 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Rob Herring
Cc: phone-devel, ~postmarketos/upstreaming, linux-arm-msm, devicetree,
Andy Gross, Konrad Dybcio, Alim Akhtar, Avri Altman,
Bart Van Assche, Krzysztof Kozlowski, linux-scsi, linux-kernel
On 9/6/22 11:29, Krzysztof Kozlowski wrote:
> On 03/09/2022 19:41, Iskren Chernev wrote:
>> Add SM6115 UFS to DT schema.
>>
>> Signed-off-by: Iskren Chernev <iskren.chernev@gmail.com>
>> ---
>> .../devicetree/bindings/ufs/qcom,ufs.yaml | 26 +++++++++++++++++++
>> 1 file changed, 26 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> index f2d6298d926c..be55a5dfc68f 100644
>> --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml
>> @@ -28,6 +28,7 @@ properties:
>> - qcom,msm8998-ufshc
>> - qcom,sc8280xp-ufshc
>> - qcom,sdm845-ufshc
>> + - qcom,sm6115-ufshc
>> - qcom,sm6350-ufshc
>> - qcom,sm8150-ufshc
>> - qcom,sm8250-ufshc
>> @@ -178,6 +179,31 @@ allOf:
>> minItems: 1
>> maxItems: 1
>>
>> + - if:
>> + properties:
>> + compatible:
>> + contains:
>> + enum:
>> + - qcom,sm6115-ufshc
>> + then:
>> + properties:
>> + clocks:
>> + minItems: 8
>> + maxItems: 8
>> + clock-names:
>> + items:
>> + - const: core_clk
>> + - const: bus_aggr_clk
>> + - const: iface_clk
>> + - const: core_clk_unipro
>> + - const: core_clk_ice
>
> This still is not naming and order of sdm845.
Yes, this will come in v3. v2 was released before we finished discussing this issue.
>> + - const: ref_clk
>> + - const: tx_lane0_sync_clk
>> + - const: rx_lane0_sync_clk
>
> Best regards,
> Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-09-06 8:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20220903174150.3566935-1-iskren.chernev@gmail.com>
2022-09-03 17:41 ` [PATCH v2 1/9] dt-bindings: ufs: qcom: Add sm6115 binding Iskren Chernev
2022-09-06 8:29 ` Krzysztof Kozlowski
2022-09-06 8:38 ` Iskren Chernev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox